Fix: gosec issues, ran go fmt and added checkout action in forgbot scan PR#1528
Open
bhanurp wants to merge 1 commit intojfrog:masterfrom
Open
Fix: gosec issues, ran go fmt and added checkout action in forgbot scan PR#1528bhanurp wants to merge 1 commit intojfrog:masterfrom
bhanurp wants to merge 1 commit intojfrog:masterfrom
Conversation
bhanurp
requested review from
a team,
agrasth,
fluxxBot,
itsmeleela,
naveenku-jfrog and
reshmifrog
and removed request for
a team
agrasth
approved these changes
Mar 16, 2026
| specPath := filepath.Join(destPath, filepath.Base(path)) | ||
| log.Info("Creating spec file at:", specPath) | ||
| // #nosec G703 G306 -- specPath is constructed from destPath within the test temp dir | ||
| err = os.WriteFile(specPath, content, 0700) |
Contributor
There was a problem hiding this comment.
File permissions of 0700 make the file executable. For a spec file (which is JSON/YAML), this is unnecessary and violates least-privilege. Should be 0644 or 0600.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description