Skip to content

Remotely delete quietly on CI pipelines #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asafgabai wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

Remotely delete quietly on CI pipelines #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21fdaf1
Remotely delete quietly on CI pipelines
asafgabai Jul 9, 2026
cc89ef4
Remotely delete quietly on CI pipelines
asafgabai Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apptrust/commands/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ var flagsMap = map[string]components.Flag{
CreateRepoFlag: components.NewBoolFlag(CreateRepoFlag, "Set to true to create the repository on the edge if it does not exist.", components.WithBoolDefaultValueFalse()),
MappingPatternFlag: components.NewStringFlag(MappingPatternFlag, "Specify along with "+MappingTargetFlag+" to distribute artifacts to a different path on the edge node. You can use wildcards to specify multiple artifacts.", func(f *components.StringFlag) { f.Mandatory = false }),
MappingTargetFlag: components.NewStringFlag(MappingTargetFlag, "The target path for distributed artifacts on the edge node. If not specified, the artifacts will have the same path and name on the edge node, as on the source Artifactory server. For flexibility in specifying the distribution path, you can include placeholders in the form of {1}, {2} which are replaced by corresponding tokens in the pattern path that are enclosed in parenthesis.", func(f *components.StringFlag) { f.Mandatory = false }),
QuietFlag: components.NewBoolFlag(QuietFlag, "Set to true to skip the confirmation message.", components.WithBoolDefaultValueFalse()),
QuietFlag: components.NewBoolFlag(QuietFlag, "Set to true to skip the confirmation message. When $CI is true, the default value is true.", components.WithBoolDefaultValueFalse()),
}

var commandFlags = map[string][]string{
Expand Down
2 changes: 1 addition & 1 deletion apptrust/commands/version/remote_delete_app_version_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func (rd *remoteDeleteAppVersionCommand) prepareAndRunCommand(ctx *components.Co

rd.applicationKey = ctx.Arguments[0]
rd.version = ctx.Arguments[1]
rd.quiet = ctx.GetBoolFlagValue(commands.QuietFlag)
rd.quiet = pluginsCommon.GetQuietValue(ctx)

if err := ValidateDistributionFlags(ctx); err != nil {
return err
Expand Down
3 changes: 3 additions & 0 deletions apptrust/commands/version/remote_delete_app_version_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/jfrog/jfrog-cli-application/apptrust/model"
"github.com/jfrog/jfrog-cli-core/v2/plugins/components"
"github.com/jfrog/jfrog-cli-core/v2/utils/config"
"github.com/jfrog/jfrog-cli-core/v2/utils/coreutils"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
Expand Down Expand Up @@ -170,6 +171,8 @@ func TestRemoteDeleteAppVersionCommand_QuietSuite(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Setenv(coreutils.CI, "false")

ctrl := gomock.NewController(t)
defer ctrl.Finish()

Expand Down
Loading