fix test due to scan-pr environment enforcement#1265
Open
eranturgeman wants to merge 1 commit intojfrog:v3_erfrom
Open
fix test due to scan-pr environment enforcement#1265eranturgeman wants to merge 1 commit intojfrog:v3_erfrom
eranturgeman wants to merge 1 commit intojfrog:v3_erfrom
Conversation
eranturgeman
added
safe to test
github-actions
bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the trigger of the OIDC yml test for 2 reasons:
The tests runs scan-pr due to the pull_request_target trigger. since we not enfore environment with reviewers on every scan-pr run we will have to approve this test all the time -not required
we dont really care what flow we run as the intention os to only validate the OIDC token so adding another approval step is redundent
Sicne the trigger was pull_reqest_target the test code that runs on every pr, doesnt really reflect the PR changes even if those were made in the test. So there is no real value to add this on every PR and we can reduce this to be run on every push