Fix elixir plugin for new Darwin SDK pattern #2764
Open
+1
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin The CoreServices framework reference was added to fix file_system package compilation on macOS (PR jetify-com#2462), but is no longer needed with the new Darwin SDK pattern introduced in nixpkgs. With the updated Darwin stdenv, the Apple SDK (including CoreServices) is now automatically provided, making the explicit framework reference obsolete. The old pattern using darwin.apple_sdk_11_0 has been removed from nixpkgs, causing installation failures on macOS. This change removes the packages section entirely and bumps the plugin version to 0.0.2. Fixes jetify-com#2705 Fixes jetify-com#2557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the elixir plugin to work with the new Darwin SDK pattern in nixpkgs by removing the explicit
darwin.apple_sdk.frameworks.CoreServicesdependency.How was it tested?
Tested on macOS (darwin-arm64):
devbox run builddevbox add elixirdarwin.apple_sdk_11_0 has been removederrorelixir --versionsuccessfully showed version informationfile_systempackage (used by Phoenix for Live Reload):file_systemdependencyCompiling file system watcher for Mac... Done.This confirms that the CoreServices framework is now automatically available through the new Darwin stdenv, and the explicit
darwin.apple_sdk.frameworks.CoreServicespackage reference is no longer needed.Background
The elixir plugin currently includes
darwin.apple_sdk.frameworks.CoreServicesin its packages section (added in #2462 (comment) to fixfile_systempackage compilation on macOS). However, this reference uses the old Darwin SDK pattern that has been removed from nixpkgs.As documented in NixOS/nixpkgs#354146, nixpkgs has migrated to a new Darwin SDK pattern where:
darwin.apple_sdk_11_0pattern cause errorsChanges
packagessection fromplugins/elixir.json0.0.1to0.0.2The
file_systempackage will continue to work on macOS because CoreServices is now automatically available through the new Darwin stdenv.Fixes #2705
Fixes #2557