{% include %} template tags do not work with non-VALID_EXTENSIONS#121
Open
deanmalmgren wants to merge 2 commits intojessemiller:masterfrom
Open
{% include %} template tags do not work with non-VALID_EXTENSIONS#121deanmalmgren wants to merge 2 commits intojessemiller:masterfrom
deanmalmgren wants to merge 2 commits intojessemiller:masterfrom
Conversation
|
+1 |
added 2 commits
January 2, 2014 17:29
… other file extensions to the hamlpy.VALID_EXTENSIONS global variable
Author
|
I took a stab at incorporating this in a manner similar to how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tend to embed inline javascript snippets by using
{% include %}django template tags like this:This is convenient because my editor can then use the appropriate javascript syntax highlighting rather than the haml syntax highlighting. The problem is that this produces a
RuntimeError(maximum recursion dept exceeded while calling a Python object) for any templates that are{% include %}-ed but do not end in one of thehamlpy.VALID_EXTENSIONS. Bummer.I might recommend making
VALID_EXTENSIONSa settings variable within the hamlpy app that can easily be extended in the site settings.py.