Skip to content

Properly disable clicks in inactive views behind popups#5313

Merged
stefanhaller merged 2 commits intomasterfrom
disable-clicks-in-inactive-views-behind-popups
Mar 8, 2026
Merged

Properly disable clicks in inactive views behind popups#5313
stefanhaller merged 2 commits intomasterfrom
disable-clicks-in-inactive-views-behind-popups

Conversation

@stefanhaller
Copy link
Collaborator

We did already have code to prevent clicks in inactive views behind a popup, but it wasn't good enough. This PR fixes two problems:

  • if the previously focused view (behind the panel) was a list view, it would look like the click would select a different row, because gocui would still set the view's cursor position, which is used to draw the highlighted row
  • it was still possible to click on tab headers, and this would dismiss the panel

Fixes #5256.

@codacy-production
Copy link

codacy-production bot commented Feb 22, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 4d08c811 26.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4d08c81) Report Missing Report Missing Report Missing
Head commit (b955002) 60217 52697 87.51%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5313) 15 4 26.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@stefanhaller stefanhaller force-pushed the disable-clicks-in-inactive-views-behind-popups branch from 8a8dc91 to af5549f Compare March 7, 2026 18:58
… panels

This fixes two problems:
- if the previously focused view (behind the panel) was a list view, it would
  look like the click would select a different row, because gocui would still
  set the view's cursor position, which is used to draw the highlighted row
- it was still possible to click on tab headers, and this would dismiss the
  panel
@stefanhaller stefanhaller force-pushed the disable-clicks-in-inactive-views-behind-popups branch from af5549f to b955002 Compare March 8, 2026 16:32
@stefanhaller stefanhaller merged commit 17e7044 into master Mar 8, 2026
13 checks passed
@stefanhaller stefanhaller deleted the disable-clicks-in-inactive-views-behind-popups branch March 8, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion: Commit description panel remains visible after tab switch when commit message panel is open

1 participant