Add refname matching for mainBranches option#5310
Open
TommyAmberson wants to merge 3 commits intojesseduffield:masterfrom
Open
Add refname matching for mainBranches option#5310TommyAmberson wants to merge 3 commits intojesseduffield:masterfrom
TommyAmberson wants to merge 3 commits intojesseduffield:masterfrom
Conversation
Use `git for-each-ref` to resolve patterns containing *, ?, or [ against both local and origin remote branches. Exact branch names continue to use `git rev-parse` for fast lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Resolves #5246.
for-each-ref uses fnmatch to match branches. I decided to only check with for-each-ref when there are glob chars present (
*?[) so that it won't effect performance for most people.Please check if the PR fulfills these requirements
go generate ./...)[ ] Text is internationalised (see here)[ ] If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)