Fix commit graph order when using --all with date-order#5307
Open
bk-simon wants to merge 1 commit intojesseduffield:masterfrom
Open
Fix commit graph order when using --all with date-order#5307bk-simon wants to merge 1 commit intojesseduffield:masterfrom
bk-simon wants to merge 1 commit intojesseduffield:masterfrom
Conversation
When toggling "show whole git graph" before changing to "date order", the commit graph was displaying in the wrong order compared to the output of `git log --graph --all --oneline`. The issue was in the order of git log arguments. The command was constructed as: git log HEAD --date-order --all But git needs --all to appear before the refSpec for proper ordering: git log --all HEAD --date-order This ensures git applies the date-order sorting to the entire graph from all refs, not just from HEAD. Fixes jesseduffield#5162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5162
Problem
When toggling "show whole git graph" before changing to "date order", the commit graph was displaying in the wrong order compared to the output of
git log --graph --all --oneline.Root Cause
The git log command was constructed with arguments in the wrong order:
This caused git to apply date-order to HEAD first, then try to apply
--all, resulting in incorrect graph ordering.Solution
Moved the
--allflag to appear before the refSpec:This ensures git applies the date-order sorting to the entire graph from all refs.
Testing
git log --graph --all --oneline