feat: remove key from built-in commands taken by custom commands#5100
Open
noahfraiture wants to merge 1 commit intojesseduffield:masterfrom
Open
feat: remove key from built-in commands taken by custom commands#5100noahfraiture wants to merge 1 commit intojesseduffield:masterfrom
noahfraiture wants to merge 1 commit intojesseduffield:masterfrom
Conversation
debcd26 to
24b9a11
Compare
feat: remove key from built-in commands taken by custom commands
24b9a11 to
09c4375
Compare
Contributor
Author
|
Hello, is there something I should do ? I don't have perm for labels I think |
Collaborator
|
Sorry for the delay. While this is a bit of an improvement, I'm still hesitant to merge it because I have the feeling we should be able to do better. Ideally I'd like to make it so that all user-defined keybindings (whether for custom commands or builtin ones) always win over builtin bindings, even if one is local and the other is global. I don't have a very clear plan how to achieve that, but I have some vague ideas that I want to try at some point. For now, other topics have higher priority for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Please check if the PR fulfills these requirements
go generate ./...)This PR aims to remove the key in keybindings for commands for which the key doesn't work because it is superseeded by a custom command.
Another possibility is to replace the key by the crossed version of the string.