Fix: Add support for line_style='dashed' in horizontal line methods#544
Closed
nickcottrell wants to merge 1 commit intojesse-ai:masterfrom
Closed
Fix: Add support for line_style='dashed' in horizontal line methods#544nickcottrell wants to merge 1 commit intojesse-ai:masterfrom
nickcottrell wants to merge 1 commit intojesse-ai:masterfrom
Conversation
Fixes jesse-ai#530 - Added 'dashed' as valid line_style option (lineStyle = 2) - Applied fix to both add_horizontal_line_to_candle_chart and add_horizontal_line_to_extra_chart - Resolves ValueError when using line_style='dashed' parameter
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530
Problem
The
add_horizontal_line_to_candle_chartandadd_horizontal_line_to_extra_chartmethods were rejecting
line_style='dashed'with aValueError, even thoughdashed lines are documented as supported.
Solution
Added
'dashed'as a valid line style option (mapped to lineStyle = 2) in bothmethods.
Changes
jesse/strategies/Strategy.py: Added elif condition for 'dashed' line style inboth horizontal line methods
Testing
Created test script (
test_line_style_fix.py) that verifies:line_style='dashed'