Skip to content

fix: invalid release tagging in npm.yml#22

Merged
jescalada merged 1 commit intorelease/1.2from
bugfix-on-1.2
May 4, 2026
Merged

fix: invalid release tagging in npm.yml#22
jescalada merged 1 commit intorelease/1.2from
bugfix-on-1.2

Conversation

@jescalada
Copy link
Copy Markdown
Owner

Fixes bug preventing NPM releases from being created due to tags being in valid semver format.

@github-actions github-actions Bot added the fix label May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Thanks for the contribution! I notice a couple of things that need attention:

Description clarity: Could you provide a bit more detail about what specifically was wrong with the tags and how your fix addresses it? This will help reviewers understand the change better.

Linked issue: I don't see a linked issue in your description. According to our contributing guidelines, PRs should either link to an existing issue using keywords like "Fixes #N" or "Closes #N", or you should create a new issue first. Could you either:

  • Link to an existing issue if this addresses one, or
  • Create a new issue describing this bug and then reference it here?

This helps us track and discuss changes properly. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

🔒 Automated Security Review

Security Review: No Issues Found

No security vulnerabilities detected in this pull request.

The change modifies the npm distribution tag format from v${MAJOR_MINOR} to release-${MAJOR_MINOR} in the GitHub workflow. This is a simple string formatting change that doesn't introduce any security risks - the tag value is still derived from the same controlled MAJOR_MINOR variable and used in the same context for npm publishing.

@jescalada jescalada merged commit 6fdb415 into release/1.2 May 4, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant