Migrate from Commons Lang to native Java Platform functionality - #103
Open
timja wants to merge 1 commit into
Open
Migrate from Commons Lang to native Java Platform functionality#103timja wants to merge 1 commit into
timja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to use a third-party library when this functionality is available in the Java Platform.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
StringUtils.isEmpty/isNotEmpty/isBlank/isNotBlank→ thehudson.Util.fixEmpty*helpers.ArrayUtils.contains(arguments, x)→Arrays.asList(arguments).contains(x)inJenkinsBrowserStackLocalTest.RandomStringUtils.random(48, letters, numbers)inTools.getUniqueStringis now a small localhelper over
SecureRandombuilding from the same letter/digit pools. Commons Lang 2 backed thatcall with a plain
java.util.Random; since the result is used as a tracking identifier I did notwant to hand-write a weaker generator. One deliberate narrowing: Commons Lang 2 would draw from the
full character range if both flags were false, whereas this version assumes at least one is set.
Both call sites pass
(true, true).io.jenkins.cli.shaded.org.apache.commons.lang.StringUtilsinQualityDashboardPipelineTracker. That is the copy of Commons Lang shaded inside the Jenkins CLIjar — almost certainly an IDE auto-import accident, and not something to depend on. It had no call
sites left after the rewrite.
No new dependency is added —
commons-lang3-apirequires core 2.479.3 and this plugin's baseline is2.334.
Testing done
mvn -B -ntp clean verifyon Java 11 / macOS: 38 tests, 6 errors — and unmodifiedmastergivesexactly the same 38 tests and 6 errors, so they are pre-existing and unrelated to this change. Five
are HtmlUnit failing on modern JS (
Cannot find function createHTMLDocument) and one is ByteBuddybeing unable to self-attach (
Can not attach to current VM).Newer JDKs do not work at all here:
maven-license-plugin:1.7throwsExceptionInInitializerErroron Java 17 and 21, again on unmodified
master.The
ban-commons-lang-2enforcer rule was left disabled because it needs parent POM6.2116.v7501b_67dc517or newer; bumping the parent from3.4was out of scope here.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact
@parameter.