Revert "Bump configuration-as-code from 1.34 to 1.35 (test harness renamed)"

[jglick]

Reverts #161. While this did not produce any test failures, it also caused the majority of plugins to be skipped. Between this and this we see

5,953 tests (-13656)

Easily seen locally, e.g.

PLUGINS=mailer TEST=InjectedTest bash local-test.sh

⇒

Failed to execute goal on project mailer: Could not resolve dependencies for project org.jenkins-ci.plugins:mailer:hpi:1.29: Could not find artifact io.jenkins:configuration-as-code:jar:tests:1.35 in repo.jenkins-ci.org

Seems that jenkinsci/configuration-as-code-plugin#917 is incompatible with plugin-compat-tester usage, as jenkinsci/configuration-as-code-plugin#1215 (comment) warned. You should choose from

• revert the rename
• restore the original artifact (I suppose just wrapping the new artifact somehow) for compatibility
• introduce a custom extension into PCT to handle the rename

[jglick]

or

• file a PR to every plugin using the old artifact, and make sure it gets merged & released

[jetersen]

I vote for

file a PR to every plugin using the old artifact, and make sure it gets merged & released

[jglick]

At least starting with the plugins mentioned here, of course. At a rough approximation:

jenkinsci$ fgrep -l configuration-as-code */pom.xml */*/pom.xml | xargs fgrep -l '<classifier>tests</classifier>'
antisamy-markup-formatter-plugin/pom.xml
ant-plugin/pom.xml
artifact-manager-s3-plugin/pom.xml
aws-secrets-manager-credentials-provider-plugin/pom.xml
azure-ad-plugin/pom.xml
azure-keyvault-plugin/pom.xml
azure-vm-agents-plugin/pom.xml
bitbucket-branch-source-plugin/pom.xml
build-failure-analyzer-plugin/pom.xml
cloudbees-folder-plugin/pom.xml
config-file-provider-plugin/pom.xml
credentials-plugin/pom.xml
dotcoverrunner-plugin/pom.xml
ec2-plugin/pom.xml
ecutest-plugin/pom.xml
external-workspace-manager-plugin/pom.xml
folder-auth-plugin/pom.xml
git-client-plugin/pom.xml
github-branch-source-plugin/pom.xml
git-plugin/pom.xml
google-compute-engine-plugin/pom.xml
google-oauth-plugin/pom.xml
hashicorp-vault-plugin/pom.xml
jira-plugin/pom.xml
mailer-plugin/pom.xml
matrix-auth-plugin/pom.xml
metrics-plugin/pom.xml
openstack-cloud-plugin/pom.xml
role-strategy-plugin/pom.xml
saml-plugin/pom.xml
script-security-plugin/pom.xml
secure-requester-whitelist-plugin/pom.xml
ssh-credentials-plugin/pom.xml
ssh-slaves-plugin/pom.xml
windows-azure-storage-plugin/pom.xml
bom/bom-latest/pom.xml
bom/sample-plugin/pom.xml

[jglick]

And ssh-credentials (maybe also ssh-slaves) is going to be tricky due to 2.190.x-specific changes.

You should really look into the second option as a provisional measure.

[timja]

I vote for

file a PR to every plugin using the old artifact, and make sure it gets merged & released

I work from the bottom you work from the top?

[jetersen]

@timja sure

[jetersen]

🦆 false postive, all good
🥉 waiting for PRs to merged and released
🥈 waiting for release
🥇 all good

antisamy-markup-formatter-plugin/pom.xml 🥈 jenkinsci/antisamy-markup-formatter-plugin#17
ant-plugin/pom.xml 🥈 jenkinsci/ant-plugin#39
artifact-manager-s3-plugin/pom.xml 🦆
aws-secrets-manager-credentials-provider-plugin/pom.xml 🥉 jenkinsci/aws-secrets-manager-credentials-provider-plugin#14
azure-ad-plugin/pom.xml 🥉 jenkinsci/azure-ad-plugin#69
azure-keyvault-plugin/pom.xml 🥈 jenkinsci/azure-keyvault-plugin#30
azure-vm-agents-plugin/pom.xml 🥈 jenkinsci/azure-vm-agents-plugin#179
bitbucket-branch-source-plugin/pom.xml 🦆
build-failure-analyzer-plugin/pom.xml 🥉 jenkinsci/build-failure-analyzer-plugin#124
cloudbees-folder-plugin/pom.xml 🥇 (v6.11) jenkinsci/cloudbees-folder-plugin#141
config-file-provider-plugin/pom.xml 🥉 jenkinsci/config-file-provider-plugin#76
credentials-plugin/pom.xml 🥇 (v2.3.1) jenkinsci/credentials-plugin#133
dotcoverrunner-plugin/pom.xml 🥈 jenkinsci/dotcoverrunner-plugin#7
ec2-plugin/pom.xml 🥈 jenkinsci/ec2-plugin#425

Taking a break 😓

[timja]

ecutest-plugin/pom.xml 🥉 jenkinsci/ecutest-plugin#137
external-workspace-manager-plugin/pom.xml 🥉 jenkinsci/external-workspace-manager-plugin#73
folder-auth-plugin/pom.xml 🥉 jenkinsci/folder-auth-plugin#47
git-client-plugin/pom.xml 🥉 jenkinsci/git-client-plugin#490
github-branch-source-plugin/pom.xml 🥉 jenkinsci/github-branch-source-plugin#266
git-plugin/pom.xml 🥉 jenkinsci/git-plugin#814
google-compute-engine-plugin/pom.xml 🥉 jenkinsci/google-compute-engine-plugin#177
google-oauth-plugin/pom.xml 🥉 jenkinsci/google-oauth-plugin#80
hashicorp-vault-plugin 🥉 jenkinsci/hashicorp-vault-plugin#68
jira-plugin/pom.xml 🥉 jenkinsci/jira-plugin#205
matrix-auth-plugin/pom.xml 🥉 jenkinsci/matrix-auth-plugin#74
metrics-plugin/pom.xml 🥉 jenkinsci/metrics-plugin#58
openstack-cloud-plugin/pom.xml jenkinsci/openstack-cloud-plugin#285
role-strategy-plugin/pom.xml 🥉 jenkinsci/role-strategy-plugin#122
saml-plugin/pom.xml 🥉 jenkinsci/saml-plugin#83
script-security-plugin/pom.xml 🥉 jenkinsci/script-security-plugin#284
secure-requester-plugin/pom.xml 🥉 jenkinsci/secure-requester-whitelist-plugin#6
ssh-credentials-plugin/pom.xml 🥇 jenkinsci/ssh-credentials-plugin#49
ssh-slaves-plugin/pom.xml 🥉 jenkinsci/ssh-agents-plugin#173
windows-azure-storage-plugin/pom.xml 🥈 jenkinsci/azure-storage-plugin#168 <- this was a pain needed test fixes when updating credentials, I feel like I'm miles behind now! 😢

[jglick]

At least starting with the plugins mentioned here

I guess when those have releases, you will file a PR to revert the reversion plus bumping those versions.

[timja]

PRs are now open for all plugins in Jesse's list, most builds are passing, need to loop back round to ~4 of them

[timja]

List of open pull requests:
https://github.com/search?q=state%3Aopen+is%3Apr+%22https%3A%2F%2Fgithub.com%2Fjenkinsci%2Fbom%2Fpull%2F164%22

[timja]

Continued in #172

[jetersen]

FYI, I did a GitHub search that revealed a few extra: https://github.com/search?q=org%3Ajenkinsci+configuration-as-code+classifier+tests+NOT+test-harness+filename%3Apom&type=Code
Here is the compile lists of the extras:

lockable-resources-plugin/pom.xml
github-plugin/pom.xml
slack-plugin/plugin.xml
audit-trail-plugin/pom.xml
github-autostatus-plugin/pom.xml
jira-plugin/pom.xml
accurev-plugin/pom.xml
vsphere-cloud-plugin/pom.xml
cloudbees-jenkins-advisor-plugin/pom.xml
openstack-cloud-plugin/pom.xml
metrics-plugin/pom.xml
gitlab-branch-source-plugin/pom.xml
google-oauth-plugin/pom.xml