Revert "fix: document does not have a valid rel=canonical"#132
Open
tchebb wants to merge 1 commit intojeffreytse:masterfrom
Open
Revert "fix: document does not have a valid rel=canonical"#132tchebb wants to merge 1 commit intojeffreytse:masterfrom
rel=canonical"#132tchebb wants to merge 1 commit intojeffreytse:masterfrom
Conversation
The SEO plugin adds a rel="canonical", so when it's enabled this makes us emit multiple, which isn't allowed. When the SEO plugin isn't enabled, it's fine not to emit a rel="canonical", since that tag exists only for SEO. Additionally, the value of this canonical tag is wrong. It always points to the root of the site, but it's supposed to point to the main URL of the current page. This reverts commit f75cca2.
jeffreytse
force-pushed
the
master
branch
3 times, most recently
from
bd29ba6 to
df61d0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SEO plugin adds a rel="canonical", so when it's enabled this makes us emit multiple, which isn't allowed. When the SEO plugin isn't enabled, it's fine not to emit a rel="canonical", since that tag exists only for SEO.
Additionally, the value of this canonical tag is wrong. It always points to the root of the site, but it's supposed to point to the main URL of the current page.
This reverts commit f75cca2.
This contribution is on behalf of my company.