Skip to content

ci: Guard release tag against project version mismatch #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffjensen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: Guard release tag against project version mismatch #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 120
environment: release
outputs:
version: ${{ steps.resolve.outputs.version }}
steps:
- uses: actions/checkout@v7
with:
Expand All @@ -33,6 +35,22 @@ jobs:
gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
gpg-passphrase: MAVEN_GPG_PASSPHRASE

# Guard against a mistyped tag releasing the wrong version: the POM is the
# source of truth for what gets deployed, so the tag must encode exactly that
# version. The resolved version also titles the GitHub Release below.
- name: Verify tag matches project version
id: resolve
env:
TAG: ${{ github.ref_name }}
run: |
version="$(${{ env.MAVEN_COMMAND }} help:evaluate -Dexpression=project.version -q -DforceStdout)"
expected="v${version}"
if [ "$TAG" != "$expected" ]; then
echo "::error::Tag '$TAG' does not match project version (expected '$expected'). Refusing to release."
exit 1
fi
echo "version=${version}" >> "$GITHUB_OUTPUT"

# Tests already ran during release:prepare; skip surefire and the archetype
# integration tests (archetype.test.skip — -DskipTests does not cover them).
- name: Deploy release to Maven Central
Expand All @@ -57,9 +75,10 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
TAG: ${{ github.ref_name }} # via env to avoid script injection
VERSION: ${{ needs.release.outputs.version }}
run: |
gh release create "$TAG" \
--repo "${{ github.repository }}" \
--title "${TAG#v}" \
--title "$VERSION" \
--generate-notes \
--verify-tag
Loading