feat: Update MergeRequestDiscussions to use MergeRequestDiscussionSchema for type consistency#3845
Open
moh3n9595 wants to merge 1 commit into
Open
feat: Update MergeRequestDiscussions to use MergeRequestDiscussionSchema for type consistency#3845moh3n9595 wants to merge 1 commit into
moh3n9595 wants to merge 1 commit into
Conversation
…ema for type consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
MergeRequestDiscussionSchemathat extendsDiscussionSchemawithnotes?: MergeRequestDiscussionNoteSchema[], so MR-specific note fields (resolved_by,resolved_at,position) are surfaced through the typed API.MergeRequestDiscussions.all,create,resolve, andshow(both interface and class) to returnMergeRequestDiscussionSchemainstead of the genericDiscussionSchema.Per the GitLab MR Discussions API docs, notes returned from MR discussion endpoints include resolution metadata (
resolved_by,resolved_at) and diffpositiondata that aren't present on notes from other discussion resources. The library already modeled this viaMergeRequestDiscussionNoteSchema, but the discussion-returning methods still typed their result asDiscussionSchema, so consumers like:only saw the generic
DiscussionNoteSchemaondiscussions[].notes. This PR threads the MR-specific schema through so the types match the actual response shape.