Fixe bug in PolyclonalAverage when sequential integer sites are being used#190
Merged
Fixe bug in PolyclonalAverage when sequential integer sites are being used#190
PolyclonalAverage when sequential integer sites are being used#190Conversation
…epitope, reverted earlier change to how sequential sites handled
…numerical precision variation
jbloom
added a commit
to dms-vep/dms-vep-pipeline-3
that referenced
this pull request
Dec 12, 2025
This is a minor bug fix update that addresses an issue with averaging models when using sequential integer sites (see [here](dms-vep/MERS-Spike-EMC2012-DMS#21) and [here](jbloomlab/polyclonal#190)).
jbloom
added a commit
to dms-vep/dms-vep-pipeline-3
that referenced
this pull request
Dec 12, 2025
This is a minor bug fix update that addresses an issue with averaging models when using sequential integer sites (see [here](dms-vep/MERS-Spike-EMC2012-DMS#21) and [here](jbloomlab/polyclonal#190)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here; the issue has to do with how sites are handled when harmonizing epitopes in
PolyclonalAveragewhen sequential integer sites are being used. This fixes the issue when there is just one epitope by simply returning a copy of the original model. In multi-epitope scenarios there may still be an error if different models only have data for subsets of sites.Specific changes (this becomes version 6.17):
6.17
PolyclonalAveragedue to epitope harmonization when sequential integer sites are being used, seehere <https://github.com/dms-vep/MERS-Spike-EMC2012-DMS/issues/21>_. This fix may only work when just one epitope is being used, with multiple epitopes there still may be issues with how the sites are assigned:models_dfinPolyclonalAverage; make a copy