Apply indentation before emitting comments on new lines#1426
Open
alexprabhat99 wants to merge 2 commits intojbeder:masterfrom
Open
Apply indentation before emitting comments on new lines#1426alexprabhat99 wants to merge 2 commits intojbeder:masterfrom
alexprabhat99 wants to merge 2 commits intojbeder:masterfrom
Conversation
Author
|
@SGSSGene I have fixed for failing tests and formatting. |
Collaborator
|
@alexprabhat99 thank you for this contribution. @jbeder this is a behavior change, without any formal specification from yaml-specs. What are your thoughts on this? |
Owner
|
I think this is fine, it's a pure ergonomic thing and the spec doesn't specify what to do here. I'd make sure it's well tested, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1392