Update CXX requirement

[mosfet80]

googletest 1.13 requires at least C++14

[mosfet80]

@jbeder

[DarthGandalf]

yaml-cpp/test/CMakeLists.txt

Line 52 in 80ea002

set_target_properties(yaml-cpp-tests PROPERTIES CXX_STANDARD 11)

needs updating too

[DarthGandalf]

googletest-1.17.0 requires C++17

[SGSSGene]

If I read correctly, this changes yaml-cpp and yaml-cpp-tests to use c++17 instead of c++11.

1. The yaml-cpp-tests target is using c++14 anyways, because of its googletests dependency. So, no real reason to adjust this, besides remove confusion and/or improve clarity... , but if(in that case I would remove the set_target_property completely and let it just inherit it from its dependencies.

2. yaml-cpp currently works fine with c++11 and doesn't need adjustment.

From my currently point of view there is no real need for adjustment, so could you please elaborate what the goal of this PR is?

[DarthGandalf]

@SGSSGene New versions of googletest require C++17, therefore yaml-cpp fails test without this patch

[SGSSGene]

@SGSSGene New versions of googletest require C++17, therefore yaml-cpp fails test without this patch

So, the issue comes up, when using for example YAML_USE_SYSTEM_GTEST.
This shows that yaml-cpp is not setting up the dependencies correctly.

We should fix how the dependency are being setup, so this issue does not appear in the future.

[SGSSGene]

This PR is currently not looking at all, as it should.
I think we should close it and someone should open a new one with a single commit.

The new PR must change the target dependencies in test/CMakeLists.txt and should not change anything else.

[DarthGandalf]

This PR is currently not looking at all, as it should. I think we should close it and someone should open a new one with a single commit.

The new PR must change the target dependencies in test/CMakeLists.txt and should not change anything else.

Nah, it's possible to force-push to same pr to reduce number of commits

[SGSSGene]

@mosfet80 thank you for the PR, if you have any questions about the Review, please feel free to ask!