Skip to content

Conversation

@jbcoe
Copy link
Owner

@jbcoe jbcoe commented Jan 31, 2026

closes #11

@jbcoe jbcoe requested a review from Copilot January 31, 2026 17:32
@jbcoe jbcoe merged commit e74dc2b into main Jan 31, 2026
9 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the libclang dependency management by using the libclang package from PyPI instead of requiring users to manually configure the library path via environment variables.

Changes:

  • Added libclang>=18.1.1 as a project dependency in pyproject.toml and uv.lock
  • Removed manual libclang path configuration code from test files and Jupyter notebook
  • Removed the PY_CPPMODEL_LIBCLANG_PATH environment variable requirement from test scripts and CI workflows
  • Updated README to remove the "Limitations" section that documented the environment variable requirement

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock Added libclang 18.1.1 package with platform-specific wheels and updated package metadata
test_py_cppmodel.py Removed environment variable check and manual library configuration
test_parse_standard_library_includes.py Removed environment variable check and manual library configuration
test.macos.sh Removed PY_CPPMODEL_LIBCLANG_PATH environment variable from test execution
pyproject.toml Added libclang>=18.1.1 to project dependencies
Sandbox.ipynb Removed manual libclang configuration cell and renumbered subsequent cells
README.md Removed "Limitations" section and updated test instructions
.github/workflows/python.yml Removed PY_CPPMODEL_LIBCLANG_PATH environment variable from CI test execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbcoe jbcoe deleted the jbcoe/libclang branch January 31, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Depend on https://pypi.org/project/libclang

2 participants