refactor: rename 'name' parameter to 'key' in sorted set methods#811
Open
oliverhaas wants to merge 2 commits intojazzband:masterfrom
Open
refactor: rename 'name' parameter to 'key' in sorted set methods#811oliverhaas wants to merge 2 commits intojazzband:masterfrom
oliverhaas wants to merge 2 commits intojazzband:masterfrom
Conversation
Changed all sorted set methods to use 'key' instead of 'name' as the parameter name for the Redis key. This improves consistency with Redis terminology where 'key' refers to the Redis key and aligns better with the rest of the codebase. Changed methods: - zadd - zcard - zcount - zincrby - zpopmax - zpopmin - zrange - zrangebyscore - zrank - zrem - zremrangebyscore - zrevrange - zrevrangebyscore - zscore All tests pass with the new parameter naming. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
======================================
Coverage 38.2% 38.2%
======================================
Files 48 48
Lines 3727 3727
Branches 301 301
======================================
Hits 1420 1420
Misses 2006 2006
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #798.
I've just chosen a bad arg naming, which I only noticed when I worked on the hash methods.
NOTE: redis-py unfortunately was the cause for this confusion. What the Redis docs call
keyisnamein the redis-py code. I suggest that this project stays withkeyfor well... the key, just like apparently everyone (incl. Redis and Valkey docs) does except the redis-py code.