feat: Return JSON error responses from webhook endpoints #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
feature/webhook-debug-info
branch
4 times, most recently
from
f468406 to
adbbcbe
Compare
PetrDlouhy
changed the title
When webhooks fail with Http404, provider dashboards show unreadable HTML. This change returns clean JSON with context for easier debugging. Changes: - Return JSON instead of raising Http404 for webhook errors - Add 'variant' field to all error responses - Add 'error_code' field for PaymentError responses - Remove token exposure from errors (security improvement) BREAKING CHANGE: Webhook endpoints now return JSON responses with status codes (400, 404) instead of raising Http404 exceptions. If you have custom code catching Http404 from webhook endpoints, update to handle JSON responses. Standard webhook systems (Stripe, PayPal) already expect JSON - no changes needed for normal usage.
PetrDlouhy
force-pushed
the
feature/webhook-debug-info
branch
from
adbbcbe to
bbf3cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When webhooks fail with
Http404, provider dashboards show unreadable HTML:This makes debugging extremely difficult - you can't tell what went wrong.
The Solution
Webhook errors now return clean JSON with context:
{"error": "Invalid payment provider", "variant": "stripe"} {"error": "Payment not found", "variant": "paypal"} {"error": "Invalid signature", "variant": "stripe", "error_code": 400}Provider dashboards now show:
Changes
variantfield to all error responseserror_codefield for PaymentError responsesBreaking Change
If you catch
Http404from webhook endpoints, update to handle JSON responses with status codes (400, 404).Note: Standard webhook systems already expect JSON - no changes needed for normal usage.