[#31] Fix player name editing regressions and harden state handling#41
Open
javaisbetterthanpython wants to merge 3 commits into
Open
[#31] Fix player name editing regressions and harden state handling#41javaisbetterthanpython wants to merge 3 commits into
javaisbetterthanpython wants to merge 3 commits into
Conversation
- Filter stale player IDs from cache and setup page load - Normalize volunteerSitoutsByRound for corrupt/missing cache entries - Extend pickleball adjective list to 30 and randomize assignment - Prevent adjective reuse across different duplicate base names - Add compact click-to-edit mode for /new setup player list - Improve player row layout with proper overflow handling - Defensive null checks for volunteerSitoutsByRound access - Disable PWA service worker in development to prevent HMR issues - Add volunteerSitouts normalization tests Closes #31 Co-authored-by: Cursor <cursoragent@cursor.com>
- Change PlayersModal PlayerNameEdit to editTrigger="click" (tap name to edit, no pencil icon), matching the /new setup page behavior - Add try/catch in worker.ts so getNextBestRound errors are reported back to the main thread instead of silently swallowing them - Add timeout (30s), proper listener cleanup, and settled guard to generateRound so the UI never gets permanently stuck on "Jumbling…" Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/newsetup page load to prevent crashesnormalizeVolunteerSitoutsByRoundto handle corrupt, missing, or truncated volunteer sitout data from older cacheseditTrigger="click") for the/newsetup player list, pencil icon retained in Players modal/newwith proper overflow handling, consistent spacing, and button sizingvolunteerSitoutsByRoundaccess ineditCourtsandeditPlayersnormalizeVolunteerSitoutsByRoundand update playerNames tests for expanded adjective listTest plan
yarn test:cipasses (4 suites, 36 tests)yarn buildpassesyarn lintpasses (only pre-existing warnings)/new, verify disambiguation with adjectivesCloses #31
Made with Cursor