[#31] Edit player names (in-game + setup)#37
Merged
Conversation
Pencil-edit UX on /new and Players modal saves on blur/Enter, snapshots historical round names, and applies pickleball adjective or numbering rules for duplicates. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
APPROVE Issue #31 acceptance criteria are met: pencil-edit on Findings
|
Align avoidability probe with getNextBestRound so the check matches how rounds are generated. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete .github/workflows/ci.yml and update orchestrator skills/docs to merge on APPROVE after local test/build/lint only. Co-authored-by: Cursor <cursoragent@cursor.com>
javaisbetterthanpython
pushed a commit
that referenced
this pull request
Jun 9, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/newand in the Players modal (active and inactive); save on blur or Enter with immediate apply in-game viarenamePlayer.playerNamesmodule with pickleball adjective disambiguation andBob (2)numbering fallback when all duplicates return to plain names.Test plan
npx jest test/playerNames.spec.ts --cipasses (11 tests)npm run buildpassesnpm run lintpasses/newand Players modal; save on blur/EnterNote:
test/heuristics.spec.tsxopponent back-to-back test fails onmainas well (pre-existing flaky seed).Closes #31
Made with Cursor