Skip to content

[#31] Edit player names (in-game + setup)#37

Merged
javaisbetterthanpython merged 4 commits into
mainfrom
issue-31-edit-player-names
Jun 9, 2026
Merged

[#31] Edit player names (in-game + setup)#37
javaisbetterthanpython merged 4 commits into
mainfrom
issue-31-edit-player-names

Conversation

@javaisbetterthanpython

Copy link
Copy Markdown
Owner

Summary

  • Add pencil-edit player names on /new and in the Players modal (active and inactive); save on blur or Enter with immediate apply in-game via renamePlayer.
  • Introduce playerNames module with pickleball adjective disambiguation and Bob (2) numbering fallback when all duplicates return to plain names.
  • Snapshot display names on each generated round; past rounds show historical names with a tooltip for the current name when it differs.

Test plan

  • npx jest test/playerNames.spec.ts --ci passes (11 tests)
  • npm run build passes
  • npm run lint passes
  • Pencil edit on /new and Players modal; save on blur/Enter
  • Inactive players renamable in Players modal
  • Past rounds show historical names; tooltip shows current name after rename
  • Duplicate names get adjectives; plain-all fallback uses numbering by player ID
  • Fixed pairs unchanged after rename (partner link by ID)

Note: test/heuristics.spec.tsx opponent back-to-back test fails on main as well (pre-existing flaky seed).

Closes #31

Made with Cursor

javaisbetterthanpython and others added 2 commits June 8, 2026 21:57
Pencil-edit UX on /new and Players modal saves on blur/Enter, snapshots historical round names, and applies pickleball adjective or numbering rules for duplicates.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@javaisbetterthanpython

Copy link
Copy Markdown
Owner Author

APPROVE

Issue #31 acceptance criteria are met: pencil-edit on /new and Players modal (blur/Enter), inactive player renames, historical round name snapshots with current-name tooltips, pickleball adjective disambiguation with plain-name numbering fallback, and renamePlayer for immediate in-game apply without round regeneration (ready for #30 pre-gen reuse). Fixed pairs remain ID-based.

Findings

javaisbetterthanpython and others added 2 commits June 8, 2026 22:09
Align avoidability probe with getNextBestRound so the check matches how rounds are generated.

Co-authored-by: Cursor <cursoragent@cursor.com>
Delete .github/workflows/ci.yml and update orchestrator skills/docs to merge on APPROVE after local test/build/lint only.

Co-authored-by: Cursor <cursoragent@cursor.com>
@javaisbetterthanpython javaisbetterthanpython merged commit ec62164 into main Jun 9, 2026
@javaisbetterthanpython javaisbetterthanpython deleted the issue-31-edit-player-names branch June 9, 2026 02:15
javaisbetterthanpython pushed a commit that referenced this pull request Jun 9, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit player names (in-game + setup)

1 participant