mono - chore: upgrade vitest to 4.1.10 and migrate biome config#1683
Merged
Conversation
Catch-up dev-tooling maintenance: - Bump vitest, @vitest/coverage-v8, and @vitest/spy from 4.1.9 to 4.1.10. - Run `biome migrate`: replace the deprecated `linter.rules.recommended: true` with `linter.rules.preset: "recommended"`, and add `root: false` to the nested benchmark config (required for nested configs in Biome 2.x). The migration is behavior-neutral: identical lint findings before and after. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P1TBuMiXotBjpNHYcbwvqf
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Biome configuration files to use the "preset": "recommended" linter rule and marks the benchmark package's Biome configuration as non-root. Additionally, it upgrades Vitest and its related coverage and spy packages from version 4.1.9 to 4.1.10, along with corresponding lockfile updates. There are no review comments, so I have no feedback to provide.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3504 3504
Branches 795 795
=========================================
Hits 3504 3504 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
No new tests are required — this is dev-tooling maintenance with no behavioral change. The existing suite continues to pass at 100% coverage.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore — catch-up dev-tooling maintenance. No runtime or public-API changes.
Changes
vitest 4.1.9 → 4.1.10 (dev dependencies, root
package.json)vitest,@vitest/coverage-v8,@vitest/spy4.1.10and its siblings are past the 48hminimumReleaseAgewindow (published 2026-07-06).biome migrate(config only)biome.jsonandpackages/benchmark/biome.json: replace the deprecatedlinter.rules.recommended: truewithlinter.rules.preset: "recommended"(the form Biome 2.5 expects — clears the deprecation left by the Biome 2.5 upgrade in mono - chore: upgrade code quality dependencies #1669).packages/benchmark/biome.json: add"root": false, required for nested configs in Biome 2.x.Verification
pnpm build— all packages build.pnpm -r --no-bail test— 8 packages fully green; the only failures are the 3 pre-existing, environment-only cases (externalmockhttp.org:8080egress; twofile-entry-cachetests that rely on non-root file-permission enforcement), all unrelated to this change and green on CI.biome check— migrated config validated; findings unchanged vs.main.Generated by Claude Code