Skip to content

cacheable - chore: upgrading lru-cache and @keyv/redis#1598

Merged
jaredwray merged 1 commit intomainfrom
cacheable---chore-upgrading-lru-cache-and-@keyv/redis
Mar 17, 2026
Merged

cacheable - chore: upgrading lru-cache and @keyv/redis#1598
jaredwray merged 1 commit intomainfrom
cacheable---chore-upgrading-lru-cache-and-@keyv/redis

Conversation

@jaredwray
Copy link
Owner

@jaredwray jaredwray commented Mar 17, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
cacheable - chore: upgrading lru-cache and @keyv/redis

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on routine dependency maintenance by upgrading two key packages: @keyv/redis and lru-cache. These updates ensure the project benefits from the latest bug fixes, performance improvements, and security patches provided by these libraries, maintaining the overall health and stability of the cacheable package. The changes are limited to version bumps and corresponding lockfile adjustments, indicating a low-risk update.

Highlights

  • Dependency Upgrades: The @keyv/redis dependency has been upgraded from version 5.1.5 to 5.1.6.
  • Dependency Upgrades: The lru-cache dependency has been upgraded from version 11.2.4 to 11.2.7.
  • Lockfile Updates: The pnpm-lock.yaml file has been updated to reflect the new dependency versions and remove outdated entries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades two development dependencies, lru-cache from ^11.2.4 to ^11.2.7 and @keyv/redis from ^5.1.5 to ^5.1.6. These are patch-level updates, which typically include bug fixes and minor improvements without introducing breaking changes. The modifications to packages/cacheable/package.json and the corresponding updates in pnpm-lock.yaml are correct. This is a routine and beneficial maintenance task. I have reviewed the changes and found no issues.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c6dcc6a) to head (b258f2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1598   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2473      2473           
  Branches       559       558    -1     
=========================================
  Hits          2473      2473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray merged commit 7f9d958 into main Mar 17, 2026
10 checks passed
@jaredwray jaredwray deleted the cacheable---chore-upgrading-lru-cache-and-@keyv/redis branch March 17, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant