Warn and reraise LoadError instead of raising custom error#143
Merged
Conversation
Owner
|
Yes, it seems correct to raise |
600801c to
3d86410
Compare
Contributor
Author
|
Yes, Tapioca doesn't care about the message. I've amended the PR. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to image_processing 2.0 and removing the image_magick gem (which we don't use) we ran into errors with Tapioca requiring all gems to compile RBI files. The quick fix was to add back image_magick, but the IMO proper fix is re-raising the original LoadError from Bundler which is handled by Tapioca. With these changes Tapioca can compile RBI for image_processing, just without the
ImageProcessing::MiniMagickmodule being present.The warn + reraise pattern is for example how Rails handles bcrypt: https://github.com/rails/rails/blob/fa8f0812160665bff083a089d2bb2fc1817ea03e/activemodel/lib/active_model/secure_password.rb#L129-L134