Fix crash in issue 3845 and defects B/C in 3779 - #3851
Open
softins wants to merge 2 commits into
Open
Conversation
softins
added
the
backport_required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR implements the two fixes listed by LLM in #3845, one of which is also Defect C listed in #3779 (comment)
It also fixes Defect B from #3779 (comment) by adding try/catch blocks around sound card initialization. This corrects the crash I observed when testing just the fixes in #3845. Exceptions should not be allowed to escape from slot functions in Qt.
CHANGELOG: Client: Avoid crashing on sound device errors.
Context: Fixes an issue?
Fixes #3845 and part of #3779 (but not the ASIO parts).
Does this change need documentation? What needs to be documented and how?
Bugfix, so probably not.
Status of this Pull Request
Ready for test.
What is missing until this pull request can be merged?
Review
Checklist