Skip to content

feat: Review Changes#14

Open
jalajcodes wants to merge 3 commits intotemp-devfrom
feat/review-changes
Open

feat: Review Changes#14
jalajcodes wants to merge 3 commits intotemp-devfrom
feat/review-changes

Conversation

@jalajcodes
Copy link
Copy Markdown
Owner

@jalajcodes jalajcodes commented Apr 1, 2022

  • Added Badge on Avatar
  • Added Badge on Icon
  • Added Icon for dark mode switcher
  • Fixed the issue : when changing the components from side nav it doesn't take to the top of the next component, but the scrolled part is preserved

Demo: https://deploy-preview-14--maxui.netlify.app/docs.html#badge

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2022

Deploy Preview for maxui ready!

Name Link
🔨 Latest commit 173c6b5
🔍 Latest deploy log https://app.netlify.com/sites/maxui/deploys/6246f26a5b386c000876e374
😎 Deploy Preview https://deploy-preview-14--maxui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown

@ApurvaSawant11 ApurvaSawant11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The badges are looking great! 💯

Try using flex utils more often. Rest everything looks good

.icon-badge i {
font-size: 2.5rem;
}
.icon-badge .badge {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the properties for .avatar-badge .badge and .icon-badge .badge are same. You can merge the common properties and only separate the ones that are different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants