[spm] Default normalize duration to true to match spanmetricsconnector#7847
[spm] Default normalize duration to true to match spanmetricsconnector#7847hxrshxz wants to merge 3 commits intojaegertracing:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a mismatch between Jaeger's default configuration and the OTel spanmetricsconnector's default behavior for metric name normalization. The spanmetricsconnector now produces normalized metric names like duration_milliseconds_bucket by default, but Jaeger was querying for the old unnormalized name duration_bucket, causing "No Data" to be displayed in the SPM Monitor tab.
Key changes:
- Updated
defaultNormalizeDurationfromfalsetotrueto align with OTel spanmetricsconnector defaults - Fixed a copy-paste bug where
NormalizeDurationwas incorrectly initialized withdefaultNormalizeCallsinstead ofdefaultNormalizeDuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Harsh <harshmastic@gmail.com>
hxrshxz
force-pushed
the
fix-spm-normalize-duration-default
branch
from
5622a0d to
2428e7c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
is this a breaking change?
| defaultLatencyUnit = "ms" | ||
| defaultNormalizeCalls = false | ||
| defaultNormalizeDuration = false | ||
| defaultNormalizeDuration = true |
There was a problem hiding this comment.
what is the implication of two different defaults for "calls" and "duration"?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
github-actions
Bot
added
the
stale
|
This pull request has been automatically closed due to inactivity. You may re-open it if you need more time. We really appreciate your contribution and we are sorry that this has not been completed. |
Which problem is this PR solving?
Fixes jaegertracing/jaeger-ui#2088
The OTel spanmetricsconnector now produces metrics with normalized names like
duration_milliseconds_bucketby default, but Jaeger's default configuration hasNormalizeDuration = false, causing queries forduration_bucket(the old metric name). This results in "No Data" being displayed for latency metrics in the SPM Monitor tab.Description of the changes
defaultNormalizeDurationfromfalsetotruein options.go to match the new OTel spanmetricsconnector default behaviorNormalizeDurationwas incorrectly initialized withdefaultNormalizeCallsinstead ofdefaultNormalizeDurationHow was this change tested?
go test ./internal/storage/metricstore/prometheus/... -vmake lintChecklist