chore(release): reassign build targets to default to v2 (Milestone 1)#7643
Closed
chore(release): reassign build targets to default to v2 (Milestone 1)#7643
Conversation
- Update BuildBinaries.mk to default JAEGER_VERSION=2 for most targets - Keep four exception targets as v1: build-all-in-one, build-query, build-collector, build-ingester - Update build-upload-a-docker-image.sh to default JAEGER_VERSION=2 - Update compute-tags.sh with v2-first documentation - Add header comments explaining override mechanism Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
The BUILD_INFO_V1 variable was not explicitly defined, causing v1 exception targets to build without version info. This fix ensures both BUILD_INFO_V1 and BUILD_INFO_V2 are properly defined. Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
Created test-v2-defaults.sh to verify: - v2 is default for non-exception targets - v1 is default for four exception targets - Override mechanism works correctly All 15 tests pass successfully. Co-authored-by: yurishkuro <3523016+yurishkuro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement milestone 1 to reassign default version to v2
chore(release): reassign build targets to default to v2 (Milestone 1)
Nov 12, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Milestone 1 from
docs/release/remove-v1-checklist.md: flip build and docker targets to produce v2 artifacts by default while preserving explicit v1 override capability.Changes
BuildBinaries.mk: Added
JAEGER_VERSIONvariable (defaults to 2). Four exception targets remain v1:build-all-in-one,build-query,build-collector,build-ingester. All other targets now useBUILD_INFO_V$(JAEGER_VERSION).BuildInfo.mk: Added missing
BUILD_INFO_V1definition (was causing v1 builds to lack version info).build-upload-a-docker-image.sh: Defaults
JAEGER_VERSION=2, passes tocompute-tags.sh.compute-tags.sh: Accepts
JAEGER_VERSIONvariable (defaults to 2).test-v2-defaults.sh: Test script verifying defaults and override mechanism (15/15 tests pass).
Usage
v1 publish/push code paths remain intact (Milestone 3 will remove them).
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.