Skip to content

Reduce object allocations in DirectionalLightShadowRenderer #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
capdevon wants to merge 5 commits into
base: master
Choose a base branch
from
+9 −6
Open

Reduce object allocations in DirectionalLightShadowRenderer #2513

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfc2c96
Update DirectionalLightShadowRenderer.java
capdevon Jun 23, 2025
7d5a0d7
DirectionalLightShadowRenderer: fix javadoc
capdevon Jun 24, 2025
2b06cbc
DirectionalLightShadowRenderer: remove unused imports
capdevon Jun 24, 2025
00d8c62
DirectionalLightShadowRenderer: restored original author name
capdevon Jul 10, 2025
3e5a21b
undo formatting and documentation
riccardobl Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions jme3-core/src/main/java/com/jme3/shadow/DirectionalLightShadowRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2021 jMonkeyEngine
* Copyright (c) 2009-2025 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -69,7 +69,8 @@ public class DirectionalLightShadowRenderer extends AbstractShadowRenderer {
protected float[] splitsArray;
protected DirectionalLight light;
protected Vector3f[] points = new Vector3f[8];
//Holding the info for fading shadows in the far distance
protected final Vector3f tempVec = new Vector3f();

private boolean stabilize = true;

/**
Expand Down Expand Up @@ -97,10 +98,12 @@ public DirectionalLightShadowRenderer(AssetManager assetManager, int shadowMapSi
}

private void init(int nbSplits, int shadowMapSize) {
nbShadowMaps = Math.max(Math.min(nbSplits, 4), 1);
if (nbShadowMaps != nbSplits) {
throw new IllegalArgumentException("Number of splits must be between 1 and 4. Given value : " + nbSplits);
// Ensure the number of shadow maps is within the valid range [1, 4]
if (nbSplits < 1 || nbSplits > 4) {
throw new IllegalArgumentException("Number of splits must be between 1 and 4. Given value: " + nbSplits);
}

nbShadowMaps = nbSplits;
splits = new ColorRGBA();
splitsArray = new float[nbSplits + 1];
shadowCam = new Camera(shadowMapSize, shadowMapSize);
Expand Down Expand Up @@ -151,7 +154,7 @@ protected void updateShadowCams(Camera viewCam) {
ShadowUtil.updateFrustumPoints(viewCam, frustumNear, zFar, 1.0f, points);

shadowCam.setFrustumFar(zFar);
shadowCam.getRotation().lookAt(light.getDirection(), shadowCam.getUp());
shadowCam.getRotation().lookAt(light.getDirection(), shadowCam.getUp(tempVec));
shadowCam.update();
shadowCam.updateViewProjection();

Expand Down