fix: EDT-threading errors in the channel console and report toolbar - #81
Open
roxblnfk wants to merge 2 commits into
Open
fix: EDT-threading errors in the channel console and report toolbar#81roxblnfk wants to merge 2 commits into
roxblnfk wants to merge 2 commits into
Conversation
fix(report): resolve report paths off the EDT Both console additions ran platform calls on the wrong thread. The channel aggregate tab appends live output from the process-reader thread, where performWhenNoDeferredOutput asserts EDT. The report toolbar polls from a Swing timer on the EDT, where getLocalPath hits the file index — a slow operation the platform forbids there. The report resolve now runs on a pool thread and drops its result if a rerun started meanwhile, so a stale apply cannot auto-open the previous run's report. Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Assisted-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Why?
Both paths called platform APIs from the wrong thread and raised IDE errors during a run:
ConsoleViewImpl.performWhenNoDeferredOutputasserts EDT, but the channel aggregate appends chunks off the process-reader thread — every live inlay threw.PhpLocalPathMapper.getLocalPathreads the file index, a slow operation the platform forbids on the EDT, and the report cells polled it twice a second from a Swing timer.Checklist
phpApivariants (252 / 262)