Update UCD section relative to last discussion with Semantics WG#61
Update UCD section relative to last discussion with Semantics WG#61loumir wants to merge 23 commits into
Conversation
Clarified the usage of Particle Data Group Identifier for particle detection and the electron case.
showing the result of recent discussions with Semantics WG
loumir
left a comment
There was a problem hiding this comment.
thanks for your careful reading.
many places changed due to the UCD related elements .
The different roles between the column names , using the dedicated language of the specific domain , here high energy , and the UCD terms using a more general language to foster crosswalks between the various usage in other spectral domains , should be clear in the note.
iannevans
left a comment
There was a problem hiding this comment.
Added a few comments and recommended changes where I thought they made sense.
| \subsubsection{Instrument-related Quantities} | ||
|
|
||
| We propose to add a new UCD {\em instr.event\/} as the base of the hierarchy to describe instrument-related properties of particle events detected by \gls{HEA} detectors. Initially, we propose a small set of event-related UCDs that identify key properties that are particularly important for \gls{HEA} data analysis. | ||
| We propose to add a new UCD {\em instr.detection\/} as the base of the hierarchy to describe instrument-related properties of particle events detected by \gls{HEA} detectors. Initially, we propose a small set of event-related UCDs that identify key properties that are particularly important for \gls{HEA} data analysis. |
There was a problem hiding this comment.
As I've argued before, instr.detection is in my view worse than instr.event because "detection" has a real and widely used meaning.
There was a problem hiding this comment.
Agree with you. But as it is just an UCD, I am in favor to make this compromise
| P & {\em stat.error.positive\/} & Positive statistical error \cr | ||
| P & {\em stat.lowerlimit\/} & Lower limit \cr | ||
| P & {\em stat.upperlimit\/} & Upper limit \cr | ||
| % Mireille we cannot have these terms in the UCD tree ; that would imply importing all possible encoding of any kind |
There was a problem hiding this comment.
I disagree about phys.particle.pdgid. phys.particle.pdgid is a UCD that identifies a Particle Group Identifier, for example a column in a FITS file that records the pdgid for each event. It's not the same as UCDs that encode all possible pdgids as part of the UCD name.
Ok for me Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
+1 Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Updated UCD descriptions for event grade, type, and physical quantities in HighEnergyObsCoreExt.tex.
loumir
left a comment
There was a problem hiding this comment.
I hope I filled the changes . I am not used to the GitHub on line editor , so what is taken into account for the PDF compilation is not clear to me.
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
Co-authored-by: Ian Nigel Evans <ievans@cfa.harvard.edu>
bkhelifi
left a comment
There was a problem hiding this comment.
Thanks a lot to all! OK for me
|
@iannevans: a very last short question about |
We want to bring proposal_id into line with facility_name and instrument_name, which are the other two "provenance" attributes in ObsCore. They already support multiple values. For facility_name, the REC says "For combined observations stemming from multiple facilities the name may contain a list of comma separated strings, or the word "Many"; if the list is too long, as defined in the VODataservice specification." and instrument_name states "Multiple values are also allowed for complex observations as defined for facility name." For proposal_id, could recommending adding the same sentence (i.e.,) "Multiple values are also allowed for complex observations as defined for facility name." but I'm not convinced it's necessary. |
1 similar comment
We want to bring proposal_id into line with facility_name and instrument_name, which are the other two "provenance" attributes in ObsCore. They already support multiple values. For facility_name, the REC says "For combined observations stemming from multiple facilities the name may contain a list of comma separated strings, or the word "Many"; if the list is too long, as defined in the VODataservice specification." and instrument_name states "Multiple values are also allowed for complex observations as defined for facility name." For proposal_id, could recommending adding the same sentence (i.e.,) "Multiple values are also allowed for complex observations as defined for facility name." but I'm not convinced it's necessary. |
| \paragraph{Event Grade} | ||
|
|
||
| For imaging X-ray instruments (especially those based on CCD detectors), detected events typically deposit charge into more than a single detector pixel. The events are assigned a ``grade'' based on how charge is deposited into the central pixel and surrounding pixels, and the grade information is essential for data analysis since typically only a subset of grades will correspond to valid events. We propose to add a new UCD {\em instr.event.grade\/} that identifies event grades. | ||
| For imaging X-ray instruments (especially those based on CCD detectors), detected events typically deposit charge into more than a single detector pixel. The events are assigned a ``grade'' based on how charge is deposited into the central pixel and surrounding pixels, and the grade information is essential for data analysis since typically only a subset of grades will correspond to valid events. We propose to use these combined UCD terms {\em meta.code.class;instr.detection\/} to provide the UCD string for the {\bf event\_grade} column. |
There was a problem hiding this comment.
"for the {\bf event_grade} column" is not correct because there is no standardization of the names of columns such as this from instrument to instrument or from facility to facility. We certainly don't use the column name "event_grade" anywhere: our ACIS event lists have two columns that identify event grades: grade and fltgrade (but other instruments/facilities use different column names). This is the same issue I've raised repeatedly - without a UCD specifically for event grade, "meta.code.class;instr.detection" does nothing to help interoperability across HEA facilities.
| For many X-ray and gamma-ray instruments, the signal observed in a given detector spectral channel is the result of event counting and would typically be recorded as a Pulse Height Amplitude (PHA), or perhaps a Pulse Invariant (PI) value that is calculated from PHA by applying an appropriate gain calibration. The PHA (or PI) can be related to the incident particle energy by applying the appropriate {\bf response-function}, and higher data calibration level products may replace or augment these values with quantities such as energy, or perhaps particle or energy flux. | ||
|
|
||
| There is currently no UCD defined for a raw pulse height amplitude measure like PHA (or PI). PHA is such an important quantity to \gls{HEA} datasets that we propose adding a new UCD {\em instr.event.pulseHeight\/} for these raw data values. We note that the background signal (both of instrumental and cosmological origin) may be significant for many \gls{HEA} detectors and so the detected events may be unrelated to any observed source on the sky. For Cherenkov neutrino detectors, this quantity might refer to the number of observed photon hits from secondary particle photon generation. | ||
| There is currently no UCD defined for a raw pulse height amplitude measure like PHA (or PI). PHA is such an important quantity to \gls{HEA} datasets that we propose adding a new UCD {\em instr.pulse\/} for these raw data values, that can be combined with more general UCD terms to describe parameters of the pulse, like {\em instr.pulse;stat.max}, {\em instr.pulse;arith.sum} as an integrated quantity, {\em instr.pulse;stat.fwmh}, etc. We note that the background signal (both of instrumental and cosmological origin) may be significant for many \gls{HEA} detectors and so the detected events may be unrelated to any observed source on the sky. For Cherenkov neutrino detectors, this quantity might refer to the number of observed photon hits from secondary particle photon generation. |
There was a problem hiding this comment.
| There is currently no UCD defined for a raw pulse height amplitude measure like PHA (or PI). PHA is such an important quantity to \gls{HEA} datasets that we propose adding a new UCD {\em instr.pulse\/} for these raw data values, that can be combined with more general UCD terms to describe parameters of the pulse, like {\em instr.pulse;stat.max}, {\em instr.pulse;arith.sum} as an integrated quantity, {\em instr.pulse;stat.fwmh}, etc. We note that the background signal (both of instrumental and cosmological origin) may be significant for many \gls{HEA} detectors and so the detected events may be unrelated to any observed source on the sky. For Cherenkov neutrino detectors, this quantity might refer to the number of observed photon hits from secondary particle photon generation. | |
| There is currently no UCD defined for a raw pulse height amplitude measure like PHA (or PI). PHA is such an important quantity to \gls{HEA} datasets that we propose adding a new UCD {\em instr.pulse\/} for these raw data values. {\em instr.pulse\/} can be combined with more general UCD terms to describe pulse parameters recorded by the pulse height analyzer electronics. Typically, PHA corresponds to the integrated signal detected by the electronics, which could therefore be described using the UCD {\em instr.pulse;arith.sum}. For some detectors, additional pulse parameters such as the peak pulse height or pulse width are important, and could be described by UCDs {\em instr.pulse;stat.max} and {\em instr.pulse;stat.fwmh}, respectively, and so on. We note that the background signal (both of instrumental and cosmological origin) may be significant for many \gls{HEA} detectors and so the detected events may be unrelated to any observed source on the sky. For Cherenkov neutrino detectors, this quantity might refer to the number of observed photon hits from secondary particle photon generation. |
| \paragraph{Event Type} | ||
|
|
||
| For \gls{VHE} (and GeV) gamma-ray data, there is the notion of event type (see \S~\ref{sec:evttype}) that can be mandatory for some data releases. We propose to add a new UCD {\em instr.event.type\/} that identifies these data values. | ||
| For \gls{VHE} (and GeV) gamma-ray data, there is the notion of event type (see \S~\ref{sec:evttype}) that can be mandatory for some data releases. We propose to use a combined UCD {\em meta.code.class;instr.detection\/} to tag the proposed {\bf event\_type} parameter. |
There was a problem hiding this comment.
Would "to tag event type" make more sense? Similar comment to "event_grade": assuming all instruments/facilities use "event_type" as a column name is too optimistic.
| One should note that electrons are denoted by the UCD {\em phys.electron\/} in the current version of the UCD list \citep{2024ivoa.spec.1218C} and are inappropriately not grouped under the {\em phys.particle\/} hierarchy. This causes some inconsistencies that could be solved by marking {\em phys.electron\/} (and {\em phys.electron.degen\/}) as obsolete or not recommended, and adding the term {\em phys.particle.electron\/} to the UCD list. | ||
| One should note that electrons are denoted by the UCD {\em phys.electron\/} in the current version of the UCD list \citep{2024ivoa.spec.1218C} and are not grouped under the {\em phys.particle\/} hierarchy. | ||
| Marking {\em phys.electron\/} (and {\em phys.electron.degen\/}) as obsolete or not recommended and adding the term {\em phys.particle.electron\/} to the UCD list would improve the consistency of the {\em phys.particle\/} branch. | ||
| However, as many data sets in the IVOA projects may already be tagged with {\em phys.electron\/} this may require maintenance costs that should be evaluated. |
There was a problem hiding this comment.
| However, as many data sets in the IVOA projects may already be tagged with {\em phys.electron\/} this may require maintenance costs that should be evaluated. | |
| However, as many data sets in the IVOA projects may already be tagged with {\em phys.electron\/} this may incur maintenance costs that should be evaluated. |
iannevans
left a comment
There was a problem hiding this comment.
I made a few suggestions but this is definitely converging. There's a question for Bruno hidden in my comment on the description of phys.pulse ;-)
I would like the results of the semantics WG discussions that happened to appear in this note. This was part of the work all along the year.
Therefore in the listed requirements for UCD we should use the terms that have been recently discussed and approved by the semantics group .
I have updated various parts of this section and included %comments to explain the changes .