Open
Conversation
github-actions
bot
added
In progress
alxmcs
requested changes
Mar 19, 2026
Comment on lines
+13
to
+17
| public CacheService(IDistributedCache cache, ILogger<CacheService> logger) | ||
| { | ||
| _cache = cache; | ||
| _logger = logger; | ||
| } |
Collaborator
There was a problem hiding this comment.
Здесь и далее по коду:
Использовать праймари конструкторы
| _logger = logger; | ||
| } | ||
|
|
||
| public async Task<Employee?> RetrieveFromCache(int id) |
Collaborator
There was a problem hiding this comment.
Здесь и далее по коду:
Добавить саммари ко всем классам, методам, публичным проперти. Если они описаны в базовом классе или интерфейсе - использовать ///<inheritdoc/>
| /// <returns>Оклад</returns> | ||
| private static decimal CalculateSalary(string position) | ||
| { | ||
| Faker faker = new(); |
Collaborator
There was a problem hiding this comment.
имхо var faker = new Faker(); будет предпочтительнее в современном шарпе
| /// <summary> | ||
| /// Справочник категорий суффиксов должностей | ||
| /// </summary> | ||
| private static readonly string[] _suffexies = { "Junior", "Middle", "Senior", "Lead" }; |
Comment on lines
+42
to
+53
| return position switch | ||
| { | ||
| var p when p.Contains("Junior") => | ||
| Math.Round(faker.Random.Decimal(30000m, 60000m), 2), | ||
| var p when p.Contains("Middle") => | ||
| Math.Round(faker.Random.Decimal(60000m, 120000m), 2), | ||
| var p when p.Contains("Senior") => | ||
| Math.Round(faker.Random.Decimal(120000m, 200000m), 2), | ||
| var p when p.Contains("Lead") => | ||
| Math.Round(faker.Random.Decimal(150000m, 250000m), 2), | ||
| _ => Math.Round(faker.Random.Decimal(40000m, 100000m), 2) | ||
| }; |
Collaborator
There was a problem hiding this comment.
Как будто бы эту логику можно было бы реализовать попроще и, возможно, даже в рамках инлайн лямбды, если бы _suffexies не массивом строк, а словарем с ключами в виде должностей и значениями в виде границ зп
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ФИО: Золотилов Никита
Номер группы: 6513
Номер лабораторной: 1
Номер варианта: 40
Краткое описание предметной области: Сотрудник компании
Краткое описание добавленных фич: Добавлен сервис генерации, кэширование и логирование