Skip to content

Feature/dev setup#11

Open
turegjorup wants to merge 8 commits intodevelopfrom
feature/dev-setup
Open

Feature/dev setup#11
turegjorup wants to merge 8 commits intodevelopfrom
feature/dev-setup

Conversation

@turegjorup
Copy link
Contributor

@turegjorup turegjorup commented Mar 24, 2026

Link to ticket

https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=7041&fromDate=2026-03-23&toDate=2026-03-29#/tickets/showTicket/7041

Description

  • Modernize development environment with Taskfile, Docker test matrix (PHP 8.3/8.4/8.5), PHPStan at max level, and Docker-based linters (markdownlint, Prettier)
  • Replace monolithic pr.yaml CI workflow with dedicated per-check workflows
  • Add PHPUnit test suite — 20 tests, 88% line coverage (100% on all service classes)
  • Fix all PHPStan errors and code style issues
  • Update README and CONTRIBUTING docs with Taskfile commands
  • Remove legacy node/yarn tooling

Screenshot of the result

If your change affects the user interface, you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist, you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

turegjorup and others added 7 commits March 24, 2026 12:06
Modernize development environment with PHP 8.3+ base image, test matrix
services, Taskfile-based workflow, PHPStan, PHPUnit, and updated linter
configs. Remove legacy node/yarn tooling in favor of Docker-based
markdownlint and prettier.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Split pr.yaml into dedicated changelog, composer, markdown, php, and yaml
workflows. Update release workflow to use checkout@v6 and fix quoting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add @var, @param, and @return type hints to resolve all 15 PHPStan
errors for mixed type arguments from Symfony InputInterface and
upstream Vault library.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
20 tests covering VaultEnvResolver, VaultLoginCommand,
VaultSecretCommand, Service\Vault, and ItkDevVaultBundle configuration.
All four service classes at 100% line coverage.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace legacy composer/yarn/node commands with Taskfile-based workflow.
Document test, lint, analyze, and CI commands. Update CI badge URL.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@turegjorup turegjorup requested a review from cableman March 24, 2026 11:29
@turegjorup turegjorup self-assigned this Mar 24, 2026
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

- Include --profile ci in test:matrix:reset so vendor volumes are
  actually removed
- Remove stale host composer.lock before composer update in test:run
- Use method_exists() for Application::addCommand() vs add() to
  support both Symfony 6.4 and 8.0

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants