Skip to content

Feature/6654 symfony upgrade#63

Merged
turegjorup merged 26 commits intodevelopfrom
feature/6654_symfony_upgrade
Mar 25, 2026
Merged

Feature/6654 symfony upgrade#63
turegjorup merged 26 commits intodevelopfrom
feature/6654_symfony_upgrade

Conversation

@turegjorup
Copy link
Contributor

@turegjorup turegjorup commented Mar 19, 2026

Link to ticket

https://leantime.itkdev.dk/dashboard/show#/tickets/showTicket/6654

Description

  • Update to PHP 8.5
  • Update Symfony with dependencies
  • Update to EasyAdmin 5.x
  • Update to DoctrineBundle 3.x
  • Update to PHPUnit 13

@todo Awaiting Symfony 8 compatibility from itk-dev/openid-connect-bundle#27
@todo Update itk-dev docker templates and github actions templates

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

turegjorup and others added 10 commits March 19, 2026 10:45
Upgrade easycorp/easyadmin-bundle from 4.x to 5.x and
doctrine/doctrine-migrations-bundle from 3.x to 4.x.

EasyAdmin 5 breaking changes addressed:
- Add #[AdminDashboard] attribute, remove #[Route] from index()
- Replace MenuItem::linkToCrud() with MenuItem::linkTo()
- Update FieldInterface::new() signature in all 14 custom fields
- Replace CrudControllerRegistry with AdminControllerRegistryInterface
- Replace ea. global variable with ea() function in templates

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@turegjorup turegjorup requested a review from cableman March 19, 2026 11:41
@turegjorup turegjorup self-assigned this Mar 19, 2026
turegjorup and others added 4 commits March 25, 2026 11:13
- Migrate Serializer\Annotation to Serializer\Attribute namespace (9 entities)
- Remove eraseCredentials() from User and Server (removed from UserInterface)
- Set explicit default_protocol on UrlType (default changed to null)
- Fix routing resources from .xml to .php (framework, web_profiler)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tection

Replace the old api-spec.yml (Java-based openapitools/openapi-diff, task runner)
with a new api-spec.yaml using oasdiff (Go, FOSS). Fixes file name mismatch
(spec.yaml -> api-spec-v1.yaml), uses docker compose pattern, and adds path
filtering. Remove redundant apispec job from pr.yaml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 25, 2026

API Specification - Breaking changes detected

API Changelog 0.0.0 vs. 0.0.0

API Changes

POST /api/detection_results

  • ⚠️ removed the media type 'application/json' for the response with the status '202'
  • ⚠️ removed the media type 'application/ld+json' for the response with the status '202'
  • ⚠️ the response property 'status' became nullable for the status '400' (media type: application/json)
  • ⚠️ the response property 'status' became nullable for the status '400' (media type: application/problem+json)
  • ⚠️ the response property 'status' became nullable for the status '400' (media type: application/ld+json)
  • added the optional property 'violations/items/code' to the response with the '422' status (media type: application/json)
  • added the optional property 'violations/items/code' to the response with the '422' status (media type: application/ld+json)
  • added the optional property 'violations/items/code' to the response with the '422' status (media type: application/problem+json)
  • added the optional property 'violations/items/hint' to the response with the '422' status (media type: application/json)
  • added the optional property 'violations/items/hint' to the response with the '422' status (media type: application/problem+json)
  • added the optional property 'violations/items/hint' to the response with the '422' status (media type: application/ld+json)
  • added the optional property 'violations/items/payload' to the response with the '422' status (media type: application/problem+json)
  • added the optional property 'violations/items/payload' to the response with the '422' status (media type: application/ld+json)
  • added the optional property 'violations/items/payload' to the response with the '422' status (media type: application/json)
  • the response property 'violations/items/message' became required for the status '422' (media type: application/json)
  • the response property 'violations/items/message' became required for the status '422' (media type: application/ld+json)
  • the response property 'violations/items/message' became required for the status '422' (media type: application/problem+json)
  • the response property 'violations/items/propertyPath' became required for the status '422' (media type: application/json)
  • the response property 'violations/items/propertyPath' became required for the status '422' (media type: application/ld+json)
  • the response property 'violations/items/propertyPath' became required for the status '422' (media type: application/problem+json)

Components

  • removed the schema 'ConstraintViolation-json'
  • removed the schema 'ConstraintViolation.jsonld-jsonld'

turegjorup and others added 12 commits March 25, 2026 13:02
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…aliases

- Exclude config/reference.php from php-cs-fixer (generated file triggers
  false positive from phpdoc_no_alias_tag rule)
- Add cs: aliases to all coding-standards tasks in Taskfile

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 1.69492% with 58 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@072186c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Controller/Admin/DashboardController.php 0.00% 16 Missing ⚠️
src/Admin/Field/AdvisoryCountField.php 0.00% 2 Missing ⚠️
src/Admin/Field/ChangesField.php 0.00% 2 Missing ⚠️
src/Admin/Field/ClonedByField.php 0.00% 2 Missing ⚠️
src/Admin/Field/ConfigFilePathField.php 0.00% 2 Missing ⚠️
src/Admin/Field/DomainField.php 0.00% 2 Missing ⚠️
src/Admin/Field/EolTypeField.php 0.00% 2 Missing ⚠️
src/Admin/Field/LatestStatusField.php 0.00% 2 Missing ⚠️
src/Admin/Field/RootDirField.php 0.00% 2 Missing ⚠️
src/Admin/Field/ServerTypeField.php 0.00% 2 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #63   +/-   ##
==========================================
  Coverage           ?   12.61%           
  Complexity         ?      819           
==========================================
  Files              ?      118           
  Lines              ?     2560           
  Branches           ?        0           
==========================================
  Hits               ?      323           
  Misses             ?     2237           
  Partials           ?        0           
Flag Coverage Δ
unittests 12.61% <1.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turegjorup turegjorup marked this pull request as ready for review March 25, 2026 12:34
@turegjorup turegjorup merged commit a555524 into develop Mar 25, 2026
15 of 16 checks passed
@turegjorup turegjorup deleted the feature/6654_symfony_upgrade branch March 25, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants