Popup follow-ups: teardown safety, entry pacing, sleep lint

[mmkal]

Follow-ups to the popup overlay feature (#36), bundled per review:

1. Popup teardown can't drop the main page's video

A throwing popup dispose (e.g. a screencast copy failure) aborted the parent's finalize, silently losing the main page's artifacts (cursor bugbot's catch on #36 — the fix landed on that branch minutes after the squash-merge snapshot, so it missed main).

2. Consumers never need waitForTimeout for popup videos

Deleting the demo's waitForTimeout calls broke the render — instant flows act before the popup screencast's first captured frame (annotations floating over a not-yet-visible popup), and action holds froze successive mid-slide frames, replaying the enter animation in slow motion. Now videoMode paces itself: the popup's first action holds until the popup has loaded and the enter animation window has real footage (~450ms ceiling; real auth popups load slower than that anyway). Animation windows are also protected from dead-air compression, and a render-time backstop defers any highlight that still lands mid-slide. The demo and overlay specs run with zero waitForTimeout calls.

3. page.waitForTimeout joins the timeout lint

A sleep waits whether or not the app is ready, so it now needs the same nearby justification comment as an explicit timeout:

await page.waitForTimeout(500);
// error middlewright(require-timeout-comment): Avoid waitForTimeout — a sleep waits
// whether or not the app is ready. ...

The video-mode footage specs are exempted via a new allowSleeps option in .oxlintrc.json overrides — there the sleeps are the test input shaping the recorded timeline — while the timeout-option check stays active in them.

Latest main merged in.

Before / after

All three from the same demo spec (spec/popup-overlay-demo.spec.ts).

a) Before — on main, with the spec's waitForTimeout calls papering over the flaw:

a-before-with-timeouts.mp4

b) On main with the timeouts removed — input fields float over a popup that isn't visible yet, and the enter animation plays in slow motion (holds freezing successive mid-slide frames):

b-timeouts-removed.mp4

c) This PR, no timeouts anywhere — videoMode paces the popup entry itself:

c-with-fixes-v2.mp4

🤖 Generated with Claude Code

Session: b7f6f792-6606-44be-9ec3-207eb762c4b6

---

Note

Medium Risk
Changes affect plugin teardown ordering, video render timing/compositing, and lint rules across specs—high user-visible impact but covered by new tests and targeted overrides.

Overview
Follow-ups to popup overlay video: parent teardown no longer depends on popup dispose succeeding, videoMode paces popup entry without spec waitForTimeout, and waitForTimeout is linted like explicit timeouts with footage-spec exemptions.

Teardown: addPlugins async dispose now collects failures from rejected child wraps and from throwing child asyncDispose, still runs the parent’s afterTest / afterTestFinalize, then rethrows the first child failure. A new popup spec asserts the parent finalizer runs when popup teardown throws.

Popup video pacing: The first action on a popup waits for load (bounded timeout) and until ~450ms after open so screencast footage covers the enter animation. Render path adds subtractVideoSpans so dead-air compression cannot eat enter/exit windows, defers highlights that still start mid-slide, and improves overlay fill-reveal compositing when sparse child frames lag state.

Lint & specs: middlewright/require-timeout-comment reports bare waitForTimeout unless a justified comment is nearby; allowSleeps: true in .oxlintrc.json overrides for video-mode footage specs. Demo/popup specs drop manual pacing sleeps; debug-mode adds a comment for an intentional sleep.

^{Reviewed by Cursor Bugbot for commit 6776d21. Bugbot is set up for automated code reviews on this repo. Configure here.}

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/middlewright@37

commit: 6435822