Update os.listall, os.listfiles and os.listdirs#12
Open
Lemonymous wants to merge 4 commits intoitb-community:masterfrom
Open
Update os.listall, os.listfiles and os.listdirs#12Lemonymous wants to merge 4 commits intoitb-community:masterfrom
Lemonymous wants to merge 4 commits intoitb-community:masterfrom
Conversation
# Changes
- Update functions to both accept fixed paths starting with a drive letter, while at the same time keeping their current functionality exactly the same as before.
# Examples
## Same behavior as before:
- `os.listdirs("")` will still list all directories in the Into the Breach directory.
- `os.listdirs("mods")` will still list all directories in the Into the Breach mods directory.
## New capabilities:
- `os.listdirs("C:")` will list all directories in the C directory.
- `os.listdirs("D:")` will list all directories in the D directory.
- `os.listdirs(GetSavedataLocation())` will list all directories in the Into the Breach save directory.
# Why not use io.popen or os.execute instead?
- Listing files and directories using io.popen or os.execute causes a program to briefly open, which can cause flickering issues which negatively impact the player experience.
Author
|
I am going to make these modifications to the functions with a separate dll in my own project that uses it, but decided to add this pull request with the same changes in the event someone continues work on this repo sometimes in the future. |
kartoFlane
force-pushed
the
master
branch
2 times, most recently
from
de06082 to
dcf22e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Examples
Same behavior as before:
os.listdirs("")will still list all directories in the Into the Breach directory.os.listdirs("mods")will still list all directories in the Into the Breach mods directory.New capabilities:
os.listdirs("C:")will list all directories in the C directory.os.listdirs("D:")will list all directories in the D directory.os.listdirs(GetSavedataLocation())will list all directories in the Into the Breach save directory.Why not use io.popen or os.execute instead?