Skip to content

Fix concurrent access to result map when merging coverage #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssams wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

Fix concurrent access to result map when merging coverage #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,17 +418,19 @@ class NYC {
}

async getCoverageMapFromAllCoverageFiles (baseDirectory) {
const map = libCoverage.createCoverageMap({})
const files = await this.coverageFiles(baseDirectory)

await pMap(
const reports = await pMap(
files,
async f => {
const report = await this.coverageFileLoad(f, baseDirectory)
map.merge(report)
},
f => this.coverageFileLoad(f, baseDirectory),
{ concurrency: os.cpus().length }
)
const map = reports.reduce((m, report) => {
m.merge(report)
return m
},
libCoverage.createCoverageMap({})
)

map.data = await this.sourceMaps.remapCoverage(map.data)

Expand Down