test: add full e2e tests

[isometry]

No description provided.

[Copilot]

Pull Request Overview

Adds full end-to-end tests for the GitHub Token Manager using Ginkgo and Kind-based clusters.

• Extended test utilities with RSA key generation, GitHub token validation, and Kind image loading.
• Implemented E2E test helpers and comprehensive tests for Token and ClusterToken CRs and Helm chart install/uninstall.
• Updated internal reconciliation conditions to use 'Ready' status and adjusted Makefile targets.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/utils/utils.go	Enhanced command runner and added RSA/GitHub utilities
test/e2e/helpers.go	Introduced helper methods for Kubernetes checks
test/e2e/e2e_test.go	Added Ginkgo E2E tests for Token and ClusterToken CRs
test/e2e/e2e_suite_test.go	Updated suite setup to use consistent GinkgoWriter
internal/tokenmanager/token_secret.go	Changed condition type from 'Available' to 'Ready'
api/v1/conditions.go	Renamed constant to ConditionTypeReady
Makefile	Updated test-e2e target and added KO variable support

Comments suppressed due to low confidence (3)

test/e2e/helpers.go:37

• [nitpick] Field name 'context' shadows the imported package and can be confusing. Consider renaming it to 'ctx' for clarity and consistency.

	context context.Context

test/e2e/e2e_suite_test.go:33

• [nitpick] Use ginkgo.GinkgoWriter for consistency with other Ginkgo v2 writes instead of the legacy GinkgoWriter.

	_, _ = fmt.Fprintf(GinkgoWriter, "Starting github-token-manager suite\n")

Makefile:154

• The '-ginkgo.v' flag is not recognized by 'go test'; either remove it or invoke the Ginkgo CLI directly with 'ginkgo' instead of 'go test'.

	KUBE_CONTEXT=kind-$(KIND_CLUSTER) go test ./test/e2e/ -tags=e2e -v -ginkgo.v