Fix tests for Archive contents table#67
Merged
isaacbrodsky merged 5 commits intoisaacbrodsky:archive-contents-tablefrom Apr 24, 2026
Merged
Fix tests for Archive contents table#67isaacbrodsky merged 5 commits intoisaacbrodsky:archive-contents-tablefrom
isaacbrodsky merged 5 commits intoisaacbrodsky:archive-contents-tablefrom
Conversation
…ersion differences
isaacbrodsky
merged commit c79ec04
into
isaacbrodsky:archive-contents-table
17 checks passed
isaacbrodsky
added a commit
that referenced
this pull request
Apr 25, 2026
* archive contents function * fix ifndef * Fix tests for Archive contents table (#67) * fix: Update error message for empty zip file case in tests * chore: Add a blank line for better readability in README * fix: Update error message for empty zip file case to reflect DuckDB version differences * fix: Improve comment clarity for error handling in read_csv tests * fix: Enhance comment clarity for empty zip file case in tests --------- Co-authored-by: Majid Hojati <mhojati@uwaterloo.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@isaacbrodsky I have made some changes in this branch to fix the tests that was failing in #65
Please let me know if it can unblock that PR