Skip to content

(LTS) Fix stonecutter #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ninjaguardian wants to merge 1 commit into
base: lts
Choose a base branch
from
+8 −2
Open

(LTS) Fix stonecutter #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/dev/isxander/yacl3/gui/image/impl/DynamicTextureImage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public DynamicTextureImage(NativeImage image, Identifier location, boolean textu
RenderSystem.assertOnRenderThread();

this.image = image;
this.texture = new DynamicTexture(/*? if >=1.21.11 >>*/ /*location::toString,*/ image);
this.texture = new DynamicTexture(/*? if >=1.21.11 >>*/location::toString, image);
// TODO 1.21.11
//? if <1.21.11
//this.texture.setFilter(textureFiltering, false);
Expand Down
8 changes: 7 additions & 1 deletion src/testmod/java/dev/isxander/yacl3/test/GuiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@ private static Screen getFullTestSuite(Screen parent) {
.append(Component.literal("b").withStyle(style -> style.withHoverEvent(createTextHoverEvent(Component.literal("b")))))
.append(Component.literal("c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c c").withStyle(style -> style.withHoverEvent(createTextHoverEvent(Component.literal("c")))))
.append(Component.literal("e").withStyle(style -> style.withHoverEvent(createTextHoverEvent(Component.literal("e")))))
.append(Component.literal("click me").withStyle(style -> style.withClickEvent(new ClickEvent.OpenUrl(URI.create("https://isxander.dev")))))
.append(Component.literal("click me").withStyle(style -> style.withClickEvent(
//? if >=1.21.5 {
new ClickEvent.OpenUrl(URI.create("https://isxander.dev"))
//?} else {
/*new ClickEvent(ClickEvent.Action.OPEN_URL, "https://isxander.dev")
*///?}
)))
)
.webpImage(imageSample("sample1.webp"))
.build())
Expand Down