Conversation
nikatza
changed the title
IGP resource, controller, and cisco nxos providerIGP resource, controller, and cisco nxos provider
nikatza
commented
Jul 11, 2025
nikatza
commented
Jul 11, 2025
felix-kaestner
force-pushed
the
rfc/device
branch
2 times, most recently
from
16f2bac to
17f847b
Compare
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
rfc/device
branch
from
17f847b to
c009bc0
Compare
Contributor
|
@nikatza Could you have a look at the failing pipelines and rebase this PR? 🙏 |
felix-kaestner
force-pushed
the
rfc/device
branch
from
c009bc0 to
3e98cbf
Compare
Contributor
Author
Done. This PR is still WIP |
nikatza
force-pushed
the
feat-add-igp
branch
2 times, most recently
from
3895c94 to
96a320a
Compare
felix-kaestner
force-pushed
the
rfc/device
branch
from
3e98cbf to
5bd24fc
Compare
nikatza
force-pushed
the
feat-add-igp
branch
6 times, most recently
from
6207a3b to
88fe06e
Compare
felix-kaestner
force-pushed
the
rfc/device
branch
from
5bd24fc to
36e038f
Compare
felix-kaestner
force-pushed
the
rfc/device
branch
6 times, most recently
from
946e79a to
1364ace
Compare
felix-kaestner
force-pushed
the
rfc/device
branch
from
e25ba55 to
5f7098b
Compare
nikatza
force-pushed
the
feat-add-igp
branch
2 times, most recently
from
15d9158 to
271fd37
Compare
nikatza
force-pushed
the
feat-add-igp
branch
2 times, most recently
from
49b6b99 to
442cc55
Compare
felix-kaestner
force-pushed
the
rfc/device
branch
from
5497e8c to
7776fa9
Compare
nikatza
force-pushed
the
feat-add-igp
branch
4 times, most recently
from
8ae35e2 to
1ac3b8c
Compare
nikatza
force-pushed
the
feat-add-igp
branch
2 times, most recently
from
0f1fbd7 to
16da247
Compare
nikatza
changed the title
IGP resource, controller, and cisco nxos providerISIS
nikatza
changed the title
ISISISIS configuration
felix-kaestner
approved these changes
Aug 18, 2025
Contributor
felix-kaestner
left a comment
felix-kaestner
left a comment
There was a problem hiding this comment.
Only some nits about comments. Nothing blocking a merge from my perspective. :)
felix-kaestner
approved these changes
Aug 18, 2025
Contributor
felix-kaestner
left a comment
felix-kaestner
left a comment
There was a problem hiding this comment.
@nikatza Pls squash all commits when merging, so we don't end up with "PR comments" commits in the history.
Configure ISIS on a NXOS device allowing the parametrization of: 1) the
instance name, 2) the Network Entitity Title, 3) the type ("Level1",
"Level2", and "Level12"), 4) the number of seconds of the on-startup
overload bit, and 5) two address families: IPv4 and IPv6 unicast. With
this package we support the minimum configuration required to build the
underlay as in this example:
```
router isis UNDERLAY
net 49.0001.0001.0000.0001.00
is-type level-1
set-overload-bit on-startup 61
address-family ipv4 unicast
address-family ipv6 unicast
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following limitations apply to the current implementation: