Rewrite OpenConfig provider without ygot/ygnmi#365
Draft
felix-kaestner wants to merge 1 commit into
Draft
Conversation
felix-kaestner
force-pushed
the
feat/openconfig
branch
from
0edd3eb to
f4e63ee
Compare
hardikdr
added
the
area/switch-automation
Replace the ygot-generated code with hand-crafted structs and gnmiext.Client, following the same patterns used by the NX-OS provider. The new implementation: - Defines Interface structs implementing gnmiext.DataElement with JSON tags derived from the OpenConfig YANG spec - Uses gnmiext.Client for gNMI Set/Get operations with automatic diff-based updates - Uses value types (not pointers) for YANG leaves that carry defaults (enabled, dhcp-client) to prevent spurious updates caused by nil vs. device-returned default mismatches - Removes ygot, ygnmi, goyang, gocloser dependencies - Removes the linter and shellcheck exclusions that were needed for generated code Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
feat/openconfig
branch
from
f4e63ee to
b09965b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the ygot-generated code with hand-crafted structs and gnmiext.Client, following the same patterns used by the NX-OS provider.
The new implementation: