Skip to content

Add AS-path set actions to RoutingPolicy CRD#244

Open
felix-kaestner wants to merge 1 commit intomainfrom
bgp-routing-policy-actions
Open

Add AS-path set actions to RoutingPolicy CRD#244
felix-kaestner wants to merge 1 commit intomainfrom
bgp-routing-policy-actions

Conversation

@felix-kaestner
Copy link
Contributor

Extend the RoutingPolicy API with a new SetASPath action under BgpActions, supporting prepend, prepend last-as, replace, and explicit AS-path operations. The API uses vendor-agnostic types with intstr.IntOrString for AS numbers (plain and dotted notation per RFC 5396) and CEL validation rules for mutual exclusivity.

@felix-kaestner felix-kaestner force-pushed the bgp-routing-policy-actions branch from df5fd02 to 2d9635a Compare March 15, 2026 14:47
@felix-kaestner felix-kaestner marked this pull request as ready for review March 15, 2026 14:47
@felix-kaestner felix-kaestner requested a review from a team as a code owner March 15, 2026 14:47
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Mar 16, 2026
@hardikdr hardikdr added this to Roadmap Mar 16, 2026
@felix-kaestner felix-kaestner force-pushed the bgp-routing-policy-actions branch 3 times, most recently from 3f5caeb to 81b1f20 Compare March 16, 2026 15:59
Extend the RoutingPolicy API with a new SetASPath action under
BgpActions, supporting prepend, prepend last-as, replace, and
explicit AS-path operations. The API uses vendor-agnostic types
with intstr.IntOrString for AS numbers (plain and dotted notation
per RFC 5396) and CEL validation rules for mutual exclusivity.
@felix-kaestner felix-kaestner force-pushed the bgp-routing-policy-actions branch from 81b1f20 to 91ac639 Compare March 20, 2026 18:27
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 62.73% (-0.20%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 10.58% (-0.09%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/routingpolicy_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.06% (-0.00%) 1562 (+19) 1 1561 (+19) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap.go 22.73% (ø) 22 5 17

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/core/routingpolicy_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/routemap_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants