-
Notifications
You must be signed in to change notification settings - Fork 4
Add OCI-based default UKI Configuration for HTTPBoot #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hardikdr
wants to merge
2
commits into
main
Choose a base branch
from
enh/default-oci-httpboot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| // SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and IronCore contributors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package oci | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "io" | ||
| "strings" | ||
|
|
||
| "github.com/containerd/containerd/remotes" | ||
| ocispec "github.com/opencontainers/image-spec/specs-go/v1" | ||
| ) | ||
|
|
||
| type FindManifestOptions struct { | ||
| // EnableCNAMECompat enables a legacy manifest selection mode based on annotations. | ||
| // This is currently only needed for backward compatibility with older PXE images. | ||
| EnableCNAMECompat bool | ||
| // CNAMEPrefix is the required prefix for the "cname" annotation when EnableCNAMECompat is set. | ||
| CNAMEPrefix string | ||
| } | ||
|
|
||
| const ( | ||
| annotationCNAME = "cname" | ||
| annotationArchitecture = "architecture" | ||
| ) | ||
|
|
||
| // FindManifestByArchitecture navigates an OCI image index to find the manifest for a specific architecture. | ||
| // If opts.EnableCNAMECompat is true, it first tries to find a manifest using the legacy CNAME annotation approach. | ||
| func FindManifestByArchitecture( | ||
| ctx context.Context, | ||
| resolver remotes.Resolver, | ||
| name string, | ||
| desc ocispec.Descriptor, | ||
| architecture string, | ||
| opts FindManifestOptions, | ||
| ) (ocispec.Manifest, error) { | ||
| manifestData, err := FetchContent(ctx, resolver, name, desc) | ||
| if err != nil { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to fetch manifest data: %w", err) | ||
| } | ||
|
|
||
| var manifest ocispec.Manifest | ||
| if err := json.Unmarshal(manifestData, &manifest); err != nil { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to unmarshal manifest: %w", err) | ||
| } | ||
|
|
||
| // If not an index, return the manifest directly. | ||
| if desc.MediaType != ocispec.MediaTypeImageIndex { | ||
| return manifest, nil | ||
| } | ||
|
|
||
| // Parse as index and find architecture-specific manifest. | ||
| var indexManifest ocispec.Index | ||
| if err := json.Unmarshal(manifestData, &indexManifest); err != nil { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to unmarshal index manifest: %w", err) | ||
hardikdr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| var targetManifestDesc ocispec.Descriptor | ||
|
|
||
| // Backward compatibility for CNAME-prefix based OCI. | ||
| if opts.EnableCNAMECompat && strings.TrimSpace(opts.CNAMEPrefix) != "" { | ||
| for _, m := range indexManifest.Manifests { | ||
| if strings.HasPrefix(m.Annotations[annotationCNAME], opts.CNAMEPrefix) && m.Annotations[annotationArchitecture] == architecture { | ||
| targetManifestDesc = m | ||
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Standard platform-based architecture lookup. | ||
| if targetManifestDesc.Digest == "" { | ||
| for _, m := range indexManifest.Manifests { | ||
| if m.Platform != nil && m.Platform.Architecture == architecture { | ||
| targetManifestDesc = m | ||
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if targetManifestDesc.Digest == "" { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to find target manifest with architecture %s", architecture) | ||
| } | ||
|
|
||
| // Fetch the nested manifest. | ||
| nestedData, err := FetchContent(ctx, resolver, name, targetManifestDesc) | ||
| if err != nil { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to fetch nested manifest: %w", err) | ||
| } | ||
|
|
||
| var nestedManifest ocispec.Manifest | ||
| if err := json.Unmarshal(nestedData, &nestedManifest); err != nil { | ||
| return ocispec.Manifest{}, fmt.Errorf("failed to unmarshal nested manifest: %w", err) | ||
| } | ||
|
|
||
| return nestedManifest, nil | ||
| } | ||
|
|
||
| // FetchContent fetches the content of an OCI descriptor using the provided resolver. | ||
| // It validates the content size matches the descriptor and returns the raw bytes. | ||
| func FetchContent(ctx context.Context, resolver remotes.Resolver, ref string, desc ocispec.Descriptor) ([]byte, error) { | ||
| fetcher, err := resolver.Fetcher(ctx, ref) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get fetcher: %w", err) | ||
| } | ||
|
|
||
| reader, err := fetcher.Fetch(ctx, desc) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to fetch content: %w", err) | ||
| } | ||
|
|
||
| defer func() { | ||
| if cerr := reader.Close(); cerr != nil { | ||
| fmt.Printf("failed to close reader: %v\n", cerr) | ||
| } | ||
| }() | ||
|
|
||
| data, err := io.ReadAll(reader) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read content: %w", err) | ||
| } | ||
|
|
||
| if int64(len(data)) != desc.Size { | ||
| return nil, fmt.Errorf("size mismatch: expected %d, got %d", desc.Size, len(data)) | ||
| } | ||
|
|
||
| return data, nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.