[irods/irods#7957] Test config: Install python-irodsclient#253
[irods/irods#7957] Test config: Install python-irodsclient#253alanking wants to merge 3 commits intoirods:mainfrom
Conversation
Checked out 1.29.2 which is the last tag for Compose V1.
Part of absorbing the metadata_guard REP is bringing in its test suite. One of its test suites uses the python-irodsclient. This change ensures that python-irodsclient pip package is installed on the containers running the tests so that the test suite can be run.
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Looks good to me.
Let's see if @trel has any opinions.
|
just requesting another glance regarding 'docker-compose' vs 'docker compose'. otherwise, good to go. |
The additions here are dealing specifically with the |
|
very well, carry on. |
|
The test for which this change is being made isn't quite working, and it's possible that we can replace it in the not-too-distant future with a C++ unit test (which obviously does not depend on python-irodsclient). We might be able to close this PR unless everybody sees the value of the submodule, as I do. :) |
|
Let's leave it open for now. I think it's unlikely that the metadata guard will land in iRODS 5 given the issues with testing. I also don't feel that's a bad thing since we still have the plugin repo. |
|
Looks like there's still a chance for the metadata guard plugin to land in iRODS 5. See irods/irods#8289 (comment). |
|
A note... docker-compose dependency has been removed as of resolution of #270. The Compose submodule would no longer be necessary. |
|
So with an update to this PR, it might be ready for merging. |
3 participants
As a workaround for #8
In service of irods/irods#7957
This is required to run one of the test suites for metadata_guard. As a plugin, it was able to avoid this by installing PRC in its test hook.