Enable ProactorEventLoop on windows for ipykernel#1469
Open
NewUserHa wants to merge 7 commits intoipython:mainfrom
Open
Enable ProactorEventLoop on windows for ipykernel#1469NewUserHa wants to merge 7 commits intoipython:mainfrom
NewUserHa wants to merge 7 commits intoipython:mainfrom
Conversation
|
Hello @NewUserHa, Thanks for your work here! Dear @ianthomas23, Is it possible to get this merged on the next release? It is really important for Windows users, as current solution creates incompatibilities between libraries. Thank you! |
Collaborator
|
@ZupoLlask It is not passing CI, so of course it will not be merged. |
|
@NewUserHa Can you please have a look at this? TY |
…on windows Removed the _init_asyncio_patch method and its calls.
Contributor
Author
|
I have no idea how this occur. this modification works in previous versions of ipython |
for more information, see https://pre-commit.ci
NewUserHa
force-pushed
the
patch-2
branch
3 times, most recently
from
37bad2c to
903b031
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1468